apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bojan Smojver" <bo...@rexursive.com>
Subject Re: svn commit: r1231605 - /apr/apr/trunk/tables/apr_hash.c
Date Wed, 25 Jan 2012 22:05:04 GMT
------- Original message -------
> From: Ruediger Pluem

> Shouldn't you store the result of res->hash_func / 
> apr_hashfunc_default_internal in a local temporary
> variable and use it later on? Otherwise you change the overlay hash and 
> may make it unusable by setting a new hash
> value. IMHO all operations by this code are currently readonly on the 
> base and overlay hash.

Yeah, good point. I was working under the assumption that overlay gets 
thrown away, which may not be true. Will fix.


View raw message