From dev-return-24485-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Tue Dec 6 20:45:06 2011 Return-Path: X-Original-To: apmail-apr-dev-archive@www.apache.org Delivered-To: apmail-apr-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4C38E9151 for ; Tue, 6 Dec 2011 20:45:06 +0000 (UTC) Received: (qmail 9585 invoked by uid 500); 6 Dec 2011 20:45:05 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 9524 invoked by uid 500); 6 Dec 2011 20:45:05 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 9515 invoked by uid 99); 6 Dec 2011 20:45:05 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Dec 2011 20:45:05 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [173.201.192.107] (HELO p3plsmtpa06-06.prod.phx3.secureserver.net) (173.201.192.107) by apache.org (qpsmtpd/0.29) with SMTP; Tue, 06 Dec 2011 20:44:58 +0000 Received: (qmail 29828 invoked from network); 6 Dec 2011 20:44:36 -0000 Received: from unknown (64.125.181.79) by p3plsmtpa06-06.prod.phx3.secureserver.net (173.201.192.107) with ESMTP; 06 Dec 2011 20:44:36 -0000 Message-ID: <4EDE7EB4.5040807@rowe-clan.net> Date: Tue, 06 Dec 2011 12:44:36 -0800 From: "William A. Rowe Jr." User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20111105 Thunderbird/8.0 MIME-Version: 1.0 To: dev@apr.apache.org Subject: Re: [PATCH] charclass matching and input check for fnmatch References: <20111206123630.GO22898@ted.stsp.name> <20111206125035.GB20362@ted.stsp.name> In-Reply-To: <20111206125035.GB20362@ted.stsp.name> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/6/2011 4:50 AM, Stefan Sperling wrote: > On Tue, Dec 06, 2011 at 01:36:30PM +0100, Stefan Sperling wrote: >> It is likely that we'll apply some intending changes on the OpenBSD side. > > I meant of course *indentation* changes :) The issue is that apr has its own style guide. Organization, bracketing etc should stay the same. Whitespace diffs are a noop, just diff --ignore-all-whitespace. There's no need to force apr conventions upon bsd or visa versa.