apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject tweaks needed to crypto configure logic
Date Sat, 10 Dec 2011 13:13:37 GMT
The following patch *seems* to address a couple of issues:

1. crypto library detection run twice (from main configure logic as
well as from APU_CHECK_CRYPTO)
2. crypto enablement depends on enablement of a crypto library, but
forgetting to enable a crypto library silently proceeds without
failing

Index: configure.in===================================================================---
configure.in	(revision 1212783)+++ configure.in	(working copy)@@
-151,8 +151,6 @@ dnl Find Expat dnl Find an iconv library
APU_CHECK_CRYPTO-APU_CHECK_CRYPTO_OPENSSL-APU_CHECK_CRYPTO_NSS
APU_FIND_LDAP APU_CHECK_DBM APU_CHECK_DBDIndex:
build/crypto.m4===================================================================---
build/crypto.m4	(revision 1212783)+++ build/crypto.m4	(working copy)@@
-34,6 +34,9 @@       APU_CHECK_CRYPTO_OPENSSL
APU_CHECK_CRYPTO_NSS       dnl add checks for other varieties of ssl
here+      if test "$apu_have_crypto" == "0"; then+
AC_ERROR(Crypto was requested but no crypto library was enabled)+
fi     fi   ], [       apu_have_crypto=0

--/--

Perhaps there is a trivial way to resolve these issues, and someone
has a round tuit:

* Using --with-crypto --with-openssl=/tmp results in the system
openssl being used.  The lack of any openssl artifacts in /tmp didn't
trigger an error.
* Using --with-crypto --with-nss (and no NSS) results in a compile
failure when prerror.h can't be found.  Should NSS detection have
aborted when the NSS pkg-config support couldn't be found?

Mime
View raw message