apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: [VOTE] Release apr-util 1.4.0
Date Wed, 07 Dec 2011 17:10:21 GMT
On Mon, Dec 5, 2011 at 8:23 PM, Graham Leggett <minfrin@sharp.fm> wrote:
> Hi all,
>
> Tarballs/zipballs are at http://apr.apache.org/dev/dist/.
>
> New in apr-util v1.4 is the apr_crypto interface, and a fix for LDAP on Solaris. Full
CHANGES are here:
> https://svn.apache.org/repos/asf/apr/apr-util/tags/1.4.0/CHANGES
>
>  +/-1
>  [  ]  Release apr-util 1.4.0 as GA

stuff to consider before 1.4.1

different autotools versions compared with 1.3.12?  (not always a
problem, but could lead to unintended glitches???)

I've been using autoconf 2.64 and libtool 1.5.26

Below are some diffs from apr-util 1.3.12 to apr-util 1.4.0 that
looked surprising to me.  Some are due to autotools, some are not.
Does anyone think any of these deserve more research?  (That's not to
say that someone might find additional diffs surprising ;) )

diff -ru apr-util-1.3.12/build/config.guess apr-util-1.4.0/build/config.guess
--- apr-util-1.3.12/build/config.guess  2011-05-19 10:58:06.000000000 -0400
+++ apr-util-1.4.0/build/config.guess   2009-11-23 09:55:11.000000000 -0500
@@ -1,10 +1,9 @@
 #! /bin/sh
 # Attempt to guess a canonical system name.
 #   Copyright (C) 1992, 1993, 1994, 1995, 1996, 1997, 1998, 1999,
-#   2000, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010
-#   Free Software Foundation, Inc.
+#   2000, 2001, 2002, 2003 Free Software Foundation, Inc.

-timestamp='2010-04-03'
+timestamp='2003-06-17'

similar for config.sub

configure:

--- apr-util-1.3.12/configure   2011-05-19 10:58:23.000000000 -0400
+++ apr-util-1.4.0/configure    2011-12-05 20:13:29.000000000 -0500
@@ -1,413 +1,81 @@
 #! /bin/sh
 # Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.64.
-#
-# Copyright (C) 1992, 1993, 1994, 1995, 1996, 1998, 1999, 2000, 2001,
-# 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009 Free Software
-# Foundation, Inc.
+# Generated by GNU Autoconf 2.59.
 #
+# Copyright (C) 2003 Free Software Foundation, Inc.
 # This configure script is free software; the Free Software Foundation
 # gives unlimited permission to copy, distribute and modify it.

I haven't checked the history, but here's an unexpected type of change:

diff -ru apr-util-1.3.12/dbd/NWGNUdbdmysql apr-util-1.4.0/dbd/NWGNUdbdmysql
--- apr-util-1.3.12/dbd/NWGNUdbdmysql   2011-03-17 21:08:15.000000000 -0400
+++ apr-util-1.4.0/dbd/NWGNUdbdmysql    2011-03-17 21:08:15.000000000 -0400
@@ -30,9 +30,6 @@
 MYSQL_IMP = libmysql.imp
 MYSQL_LIB = libmysqlclient_r.lib libz.lib
 MYSQL_NLM = libmysql
-ifneq "$(wildcard $(MYSQL_INC)/mysql.h)" "$(MYSQL_INC)/mysql.h"
-$(error MYSQLSDK does not point to a valid MySQL SDK)
-endif

 #
 # These directories will be at the beginning of the include list, followed by

diff -ru apr-util-1.3.12/include/apr_memcache.h
apr-util-1.4.0/include/apr_memcache.h
--- apr-util-1.3.12/include/apr_memcache.h      2010-09-30
23:31:56.000000000 -0400
+++ apr-util-1.4.0/include/apr_memcache.h       2010-09-30
22:59:49.000000000 -0400
@@ -287,9 +287,6 @@
  * @param data_size   length of data at baton
  * @param timeout time in seconds for the data to live on the server
  * @param flags any flags set by the client for this key
- * @bug timeout is not implemented
- * @bug timeouts for apr must be prototyped in apr_interval_time_t;
- * this changes in 2.0
  */
 APU_DECLARE(apr_status_t) apr_memcache_set(apr_memcache_t *mc,
                                            const char *key,

diff -ru apr-util-1.3.12/xml/expat/configure.in
apr-util-1.4.0/xml/expat/configure.in
--- apr-util-1.3.12/xml/expat/configure.in      2010-09-29
10:00:14.000000000 -0400
+++ apr-util-1.4.0/xml/expat/configure.in       2011-05-20
14:58:21.000000000 -0400
@@ -38,7 +38,16 @@

 AC_CONFIG_HEADER(expat_config.h)

+dnl
+dnl Include our own M4 macros along with those for libtool
+dnl
 sinclude(conftools/ac_c_bigendian_cross.m4)
+sinclude(conftools/libtool.m4)
+sinclude(conftools/ltsugar.m4)
+sinclude(conftools/argz.m4)
+sinclude(conftools/ltoptions.m4)
+sinclude(conftools/ltversion.m4)
+sinclude(conftools/lt~obsolete.m4)

 AC_CANONICAL_SYSTEM

diff -ru apr-util-1.3.12/xml/expat/conftools/ltmain.sh
apr-util-1.4.0/xml/expat/conftools/ltmain.sh
--- apr-util-1.3.12/xml/expat/conftools/ltmain.sh       2009-02-28
07:48:16.000000000 -0500
+++ apr-util-1.4.0/xml/expat/conftools/ltmain.sh        2009-11-23
09:55:11.000000000 -0500
@@ -1,8 +1,8 @@
 # ltmain.sh - Provide generalized library-building support services.
 # NOTE: Changing this file will not affect anything until you rerun configure.
 #
-# Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2003, 2004, 2005, 2006,
-# 2007, 2008  Free Software Foundation, Inc.
+# Copyright (C) 1996, 1997, 1998, 1999, 2000, 2001, 2003, 2004, 2005
+# Free Software Foundation, Inc.
 # Originally by Gordon Matzigkeit <gord@gnu.ai.mit.edu>, 1996
 #
 # This program is free software; you can redistribute it and/or modify
@@ -43,8 +43,8 @@

diff -ru apr-util-1.3.12/xml/expat/Makefile.in
apr-util-1.4.0/xml/expat/Makefile.in
--- apr-util-1.3.12/xml/expat/Makefile.in       2010-10-09
06:52:31.000000000 -0400
+++ apr-util-1.4.0/xml/expat/Makefile.in        2011-05-20
15:29:41.000000000 -0400
@@ -77,7 +77,9 @@

 extraclean: distclean
        rm -f expat_config.h.in configure
-       rm -f conftools/ltconfig conftools/ltmain.sh conftools/libtool.m4
+       rm -f conftools/aclocal.m4 conftools/ltconfig conftools/ltmain.sh
+       rm -f conftools/argz.m4 conftools/libtool.m4 conftools/ltoptions.m4
+       rm -f conftools/ltsugar.m4 conftools/ltversion.m4
conftools/lt~obsolete.m4

 check: tests/runtests
        tests/runtests




>
> Regards,
> Graham
> --
>



-- 
Born in Roswell... married an alien...

Mime
View raw message