apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: tweaks needed to crypto configure logic
Date Wed, 14 Dec 2011 22:57:55 GMT
On 10 Dec 2011, at 3:13 PM, Jeff Trawick wrote:

> The following patch *seems* to address a couple of issues:
> 
> 1. crypto library detection run twice (from main configure logic as
> well as from APU_CHECK_CRYPTO)
> 2. crypto enablement depends on enablement of a crypto library, but
> forgetting to enable a crypto library silently proceeds without
> failing

Fixed in r1214516.

> Perhaps there is a trivial way to resolve these issues, and someone
> has a round tuit:
> 
> * Using --with-crypto --with-openssl=/tmp results in the system
> openssl being used.  The lack of any openssl artifacts in /tmp didn't
> trigger an error.

Is this practical to achieve? APR depends on other libraries in the system paths, how would
you stop autoconf's tests picking up system libraries without also picking up a system openssl?

> * Using --with-crypto --with-nss (and no NSS) results in a compile
> failure when prerror.h can't be found.  Should NSS detection have
> aborted when the NSS pkg-config support couldn't be found?

That's a bit odd - if NSS is missing, in theory apu_have_nss will be '0', which in theory
means that this line will cause apr_crypto_nss.c to be not compiled and skipped:

     test $apu_have_nss = 1 && dsos="$dsos crypto/apr_crypto_nss.la"

Is there something I missed?

Regards,
Graham
--


Mime
View raw message