Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: local policy)
From: Stefan Fritsch <sf@sfritsch.de>
To: dev@httpd.apache.org,
 dev@apr.apache.org
Subject: Re: svn commit: r1204998 - /httpd/httpd/trunk/server/util_expr_eval.c
Date: Tue, 22 Nov 2011 21:53:57 +0100
User-Agent: KMail/1.13.7 (Linux/3.1.0-1-amd64; KDE/4.6.5; x86_64; ; )
References: <20111122140226.A980C238897A@eris.apache.org>
In-Reply-To: <20111122140226.A980C238897A@eris.apache.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201111222153.58354.sf@sfritsch.de>

On Tuesday 22 November 2011, jim@apache.org wrote:
> Author: jim
> Date: Tue Nov 22 14:02:25 2011
> New Revision: 1204998
> 
> URL: http://svn.apache.org/viewvc?rev=1204998&view=rev
> Log:
> Hello. Let's compile again.
> 
> Modified:
>     httpd/httpd/trunk/server/util_expr_eval.c
> 
> Modified: httpd/httpd/trunk/server/util_expr_eval.c
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/server/util_expr_ev
> al.c?rev=1204998&r1=1204997&r2=1204998&view=diff
> ==================================================================
> ============ --- httpd/httpd/trunk/server/util_expr_eval.c
> (original)
> +++ httpd/httpd/trunk/server/util_expr_eval.c Tue Nov 22 14:02:25
> 2011 @@ -29,6 +29,8 @@
>  #include "apr_lib.h"
>  #include "apr_fnmatch.h"
> 
> +#include <limits.h>     /* for INT_MAX */
> +
>  /* we know core's module_index is 0 */
>  #undef APLOG_MODULE_INDEX
>  #define APLOG_MODULE_INDEX AP_CORE_MODULE_INDEX

Interesting. On Unix and Netware, apr.h already includes limits.h. But 
on Windows it doesn't. Shouldn't that be identical on all platforms? 
Such differences don't make writing portable code any easier.