apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: svn commit: r1207680 - in /apr/apr/trunk: crypto/apr_crypto_nss.c dbd/apr_dbd_sqlite3.c dbm/apr_dbm_sdbm.c test/testreslist.c util-misc/apr_thread_pool.c
Date Mon, 28 Nov 2011 23:52:59 GMT
On 29 Nov 2011, at 01:35, William A. Rowe Jr. wrote:

> FWIW, isn't this invalid on some builds?
> 
> Don't you need to cast the ignored function rv to null?
> 
> Seems to be trading your warning for someone elses' warning.
> 
> E.g.
> 
>    (void)apr_sdbm_nextkey(dbm->file, &rd);

This definitely seems sensible. Just tried the build cast to void, and it seemed to work without
a warning (rpmbuild from Fedora Core 17). Committed in r1207704.

Regards,
Graham
--


Mime
View raw message