apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r1207680 - in /apr/apr/trunk: crypto/apr_crypto_nss.c dbd/apr_dbd_sqlite3.c dbm/apr_dbm_sdbm.c test/testreslist.c util-misc/apr_thread_pool.c
Date Mon, 28 Nov 2011 23:32:33 GMT
On 11/28/2011 5:29 PM, Graham Leggett wrote:
> On 29 Nov 2011, at 01:21, William A. Rowe Jr. wrote:
>
>>> -    rv = apr_sdbm_nextkey(dbm->file,&rd);
>>> +    apr_sdbm_nextkey(dbm->file,&rd);
>>>
>>>       pkey->dptr = rd.dptr;
>>>       pkey->dsize = rd.dsize;
>
> apr-trunk contains the following explanation for this, I understand it's intended (sf?):
>
>      /*
>       * XXX: This discards any error but apr_sdbm_nextkey currently returns
>       * XXX: an error for the last key
>       */

Interesting.  Good if that's the only case; it still seems odd ;-)

>>> -            rv = apr_thread_cond_wait(me->cond, me->lock);
>>> +            apr_thread_cond_wait(me->cond, me->lock);
>>>           }
>>>       }
>
> Again, not sure what the correct behaviour is here. The function returns void, so the
caller isn't expecting an error.

Ah, you are correct, this is not a trylock.


Mime
View raw message