From dev-return-24341-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Thu Jul 28 19:11:57 2011 Return-Path: X-Original-To: apmail-apr-dev-archive@www.apache.org Delivered-To: apmail-apr-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 74E8570A6 for ; Thu, 28 Jul 2011 19:11:57 +0000 (UTC) Received: (qmail 4324 invoked by uid 500); 28 Jul 2011 19:11:57 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 4005 invoked by uid 500); 28 Jul 2011 19:11:56 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 3995 invoked by uid 99); 28 Jul 2011 19:11:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jul 2011 19:11:55 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [209.85.215.50] (HELO mail-ew0-f50.google.com) (209.85.215.50) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 28 Jul 2011 19:11:47 +0000 Received: by ewy10 with SMTP id 10so2558093ewy.37 for ; Thu, 28 Jul 2011 12:11:26 -0700 (PDT) Received: by 10.213.34.199 with SMTP id m7mr544267ebd.134.1311880286362; Thu, 28 Jul 2011 12:11:26 -0700 (PDT) Received: from dv7 (ip92-186-173-82.adsl2.static.versatel.nl [82.173.186.92]) by mx.google.com with ESMTPS id u3sm560996eeb.10.2011.07.28.12.11.24 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 28 Jul 2011 12:11:25 -0700 (PDT) From: "Bert Huijben" To: "'William A. Rowe Jr.'" , References: <4E30B452.3090401@bigpond.com> <4E30BA45.9070404@gknw.net> <4E317B1C.70508@rowe-clan.net> In-Reply-To: <4E317B1C.70508@rowe-clan.net> Subject: RE: apr, pools and NetWare Date: Thu, 28 Jul 2011 21:10:04 +0200 Message-ID: <05fa01cc4d59$f61633a0$e2429ae0$@qqmail.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQFHRWLgWN9mK+m1CCHVNOOmK95gPwIN2CFoAjcWI06V6gE1UA== Content-Language: nl X-Virus-Checked: Checked by ClamAV on apache.org > -----Original Message----- > From: William A. Rowe Jr. [mailto:wrowe@rowe-clan.net] > Sent: donderdag 28 juli 2011 17:07 > To: dev@apr.apache.org > Subject: Re: apr, pools and NetWare >=20 > On 7/27/2011 6:24 PM, NormW wrote: > > > >> APR_DECLARE(apr_pool_t *) apr_pool_parent_get(apr_pool_t *pool) > >> { > >> #ifdef NETWARE > >> /* On NetWare, don't return the global_pool, return the = application > pool > >> as the top most pool */ > >> if (pool->parent =3D=3D global_pool) > >> return pool; > >> else > >> #endif > >> return pool->parent; > >> } > > > > Cannot see how NetWare can escape this loop if apr_pool_parent_get() > > returns the same pool passed in to the function. >=20 > That Netware apr_pool_parent_get() behaves differently is a problem. > Perhaps apr_pool_parent_get() should return NULL where it is at the > top level pool, irrespective of any special needs internally. >=20 > We've illustrated this as a design pattern in any number of places > (svn guys, please confirm if you do this, too?) so you would think > there are other places code could be uniquely broken on Netware > that are outside of our visibility. >=20 > Other thoughts? We don't use this pattern in Subversion. (We don't even have a single = call to apr_pool_parent_get() in trunk) Bert