From dev-return-24285-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Wed Jun 29 00:12:58 2011 Return-Path: X-Original-To: apmail-apr-dev-archive@www.apache.org Delivered-To: apmail-apr-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 68B156104 for ; Wed, 29 Jun 2011 00:12:58 +0000 (UTC) Received: (qmail 23791 invoked by uid 500); 29 Jun 2011 00:12:57 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 23498 invoked by uid 500); 29 Jun 2011 00:12:56 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 23489 invoked by uid 99); 29 Jun 2011 00:12:56 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jun 2011 00:12:56 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of rainer.jung@kippdata.de designates 195.227.30.149 as permitted sender) Received: from [195.227.30.149] (HELO mailserver.kippdata.de) (195.227.30.149) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Jun 2011 00:12:49 +0000 Received: from [192.168.2.101] ([192.168.2.101]) by mailserver.kippdata.de (8.13.5/8.13.5) with ESMTP id p5T0CRVP010738 for ; Wed, 29 Jun 2011 02:12:28 +0200 (CEST) Message-ID: <4E0A6DEB.3080008@kippdata.de> Date: Wed, 29 Jun 2011 02:12:27 +0200 From: Rainer Jung User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.2.18) Gecko/20110616 Thunderbird/3.1.11 MIME-Version: 1.0 To: APR Development List Subject: Re: svn commit: r1140899 - /apr/apr/trunk/crypto/apr_crypto_openssl.c References: <20110628231559.3821B23888FD@eris.apache.org> In-Reply-To: <20110628231559.3821B23888FD@eris.apache.org> X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On 29.06.2011 01:15, rjung@apache.org wrote: > Author: rjung > Date: Tue Jun 28 23:15:58 2011 > New Revision: 1140899 > > URL: http://svn.apache.org/viewvc?rev=1140899&view=rev > Log: > Remove unused variable. > > Modified: > apr/apr/trunk/crypto/apr_crypto_openssl.c > > Modified: apr/apr/trunk/crypto/apr_crypto_openssl.c > URL: http://svn.apache.org/viewvc/apr/apr/trunk/crypto/apr_crypto_openssl.c?rev=1140899&r1=1140898&r2=1140899&view=diff > ============================================================================== > --- apr/apr/trunk/crypto/apr_crypto_openssl.c (original) > +++ apr/apr/trunk/crypto/apr_crypto_openssl.c Tue Jun 28 23:15:58 2011 > @@ -98,7 +98,6 @@ static apr_status_t crypto_shutdown(void > } > > static apr_status_t crypto_shutdown_helper(void *data) { > - apr_pool_t *pool = (apr_pool_t *) data; > return crypto_shutdown(); > } Note that I removed the unsed variable to prevent a compiler warning. The code in 1.4.x and 1.5.x is different: it passes the pool along to crypto_shutdown() which then doesn't use it. I guess we want the code to be consistent, but I'm not sure, which way to prefer - pass the pool to crypto_shutdown and ignore there (1.4, 1.5), or already dropp it in crypto_shutdown_helper (trunk). Regards, Rainer