apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: svn commit: r1140899 - /apr/apr/trunk/crypto/apr_crypto_openssl.c
Date Thu, 30 Jun 2011 07:56:26 GMT
On 29 Jun 2011, at 2:12 AM, Rainer Jung wrote:

> Note that I removed the unsed variable to prevent a compiler warning.
>
> The code in 1.4.x and 1.5.x is different: it passes the pool along to
> crypto_shutdown() which then doesn't use it. I guess we want the  
> code to
> be consistent, but I'm not sure, which way to prefer - pass the pool
> to crypto_shutdown and ignore there (1.4, 1.5), or already dropp it in
> crypto_shutdown_helper (trunk).

apr-trunk, v1.5.x and v1.4.x should all be the same, and if they're  
not it's an oversight.

Regards,
Graham
--


Mime
View raw message