Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of trawick@gmail.com designates
 209.85.214.50 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=IINaIkUUzH4Xzza8yWvxn0ax+a9uJ22MZJz48m2gd8KPwSeFbf/0CDrECwX2V5wePk
         v6320cZ2NuO5lOTgtuCt0flJW3bVvLds/VcN88/b4Ey17EU3lgo+Aqu6ZlWBclhDZ4mJ
         jKiaaX8ZGsFgmRqqdN0/1FjFDYR+nNeCImwcA=
MIME-Version: 1.0
In-Reply-To: <4DD55C71.2080106@rowe-clan.net>
References: <bug-51219-43213@https.issues.apache.org/bugzilla/>
	<BANLkTimE++hXyB-_=6iTZFiBhy=nxW_5FA@mail.gmail.com>
	<4DD3F433.1070809@apache.org>
	<20110518203550.GA4495@redhat.com>
	<4DD42FB7.9060609@rowe-clan.net>
	<20110518205510.GB4495@redhat.com>
	<4DD435F7.60901@rowe-clan.net>
	<20110519145343.GA4202@redhat.com>
	<4DD559C7.1000704@rowe-clan.net>
	<4DD55C71.2080106@rowe-clan.net>
Date: Thu, 19 May 2011 16:06:51 -0400
Message-ID: <BANLkTi=HDiqibQ-m7N=zSrJxP2E7y5_gPg@mail.gmail.com>
Subject: Re: Fwd: DO NOT REPLY [Bug 51219] New: apr_fnmatch infinite loop on
 pattern "/*/WEB-INF/"
From: Jeff Trawick <trawick@gmail.com>
To: dev@apr.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Thu, May 19, 2011 at 2:07 PM, William A. Rowe Jr.
<wrowe@rowe-clan.net> wrote:
> On 5/19/2011 12:56 PM, William A. Rowe Jr. wrote:
>> [moving from embargoed to open discussion]
>>
>> On 5/19/2011 9:53 AM, Joe Orton wrote:
>>
>>> b) glibc does not match the pattern "\/" against "/" with FNM_PATHNAME
>>> set, but APR does:
>>>
>>> 0000000052585e22 apr_fnmatch(".*\//", ".//", 2) =3D 0, glibc=3D1
>>
>> Do we want to change this behavior? =A0We must still be careful of the
>> special meaning of '/' but we can force a mismatch by dropping the
>> logic at line 218-219, which quietly ignores the leading backslash.
>> Other tests for \/ must remain.
>
> I would argue to keep our behavior, based on typical shell behavior;
>
> $ ls lib\/.svn
>
> tab completion or pressing enter here both work just fine, and this
> should be reflected by our APR_FNM_PATHNAME behavior as well.

BTW, where are we on the 1.4.5-readiness front?  Things have been a
bit hectic here and I may have missed something.