Return-Path: X-Original-To: apmail-apr-dev-archive@www.apache.org Delivered-To: apmail-apr-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 45D156A69 for ; Fri, 20 May 2011 15:38:09 +0000 (UTC) Received: (qmail 184 invoked by uid 500); 20 May 2011 15:38:09 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 124 invoked by uid 500); 20 May 2011 15:38:09 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 111 invoked by uid 99); 20 May 2011 15:38:08 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 May 2011 15:38:08 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [64.202.165.30] (HELO smtpauth19.prod.mesa1.secureserver.net) (64.202.165.30) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 20 May 2011 15:38:01 +0000 Received: (qmail 30424 invoked from network); 20 May 2011 15:37:39 -0000 Received: from unknown (38.126.23.254) by smtpauth19.prod.mesa1.secureserver.net (64.202.165.30) with ESMTP; 20 May 2011 15:37:39 -0000 Message-ID: <4DD68AC5.3060207@rowe-clan.net> Date: Fri, 20 May 2011 10:37:41 -0500 From: "William A. Rowe Jr." User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: dev@apr.apache.org Subject: Re: Fwd: DO NOT REPLY [Bug 51219] New: apr_fnmatch infinite loop on pattern "/*/WEB-INF/" References: <4DD3F433.1070809@apache.org> <20110518203550.GA4495@redhat.com> <4DD42FB7.9060609@rowe-clan.net> <20110518205510.GB4495@redhat.com> <4DD435F7.60901@rowe-clan.net> <20110519145343.GA4202@redhat.com> <4DD559C7.1000704@rowe-clan.net> <20110520092903.GA9146@redhat.com> In-Reply-To: <20110520092903.GA9146@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/20/2011 4:29 AM, Joe Orton wrote: > > I've done one short run this morning with the 1.4.x tip. In the diff vs > glibc, I filtered out patterns with ']', '[' and '/' within [], and also > patterns containing \/. Only two patterns remained with different > behaviour: > > 000000009199a75c apr_fnmatch("*?[.].", "/..", 4) = 0, glibc=1 > 00000000a504a704 apr_fnmatch("*?*[^aa]", "/.", 4) = 0, glibc=1 > > the flag used is APR_FNM_PERIOD. APR looks correct for the first, I am > not sure why the second is matching. One can argue glibc is correct for both, in that the leading slash was only significant if APR_FNM_PATHNAME was given. I'd have to reread the three docs that sometimes disagree on these things. But in any case, I would not consider this a blocker, and glad to read you found no other concerning patterns!