Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (nike.apache.org: local policy)
Message-ID: <4DD55C71.2080106@rowe-clan.net>
Date: Thu, 19 May 2011 13:07:45 -0500
From: "William A. Rowe Jr." <wrowe@rowe-clan.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US;
 rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10
MIME-Version: 1.0
To: dev@apr.apache.org
Subject: Re: Fwd: DO NOT REPLY [Bug 51219] New: apr_fnmatch infinite loop
 on pattern "/*/WEB-INF/"
References: <bug-51219-43213@https.issues.apache.org/bugzilla/>
 <BANLkTimE++hXyB-_=6iTZFiBhy=nxW_5FA@mail.gmail.com>
 <4DD3F433.1070809@apache.org> <20110518203550.GA4495@redhat.com>
 <4DD42FB7.9060609@rowe-clan.net> <20110518205510.GB4495@redhat.com>
 <4DD435F7.60901@rowe-clan.net> <20110519145343.GA4202@redhat.com>
 <4DD559C7.1000704@rowe-clan.net>
In-Reply-To: <4DD559C7.1000704@rowe-clan.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 5/19/2011 12:56 PM, William A. Rowe Jr. wrote:
> [moving from embargoed to open discussion]
> 
> On 5/19/2011 9:53 AM, Joe Orton wrote:
> 
>> b) glibc does not match the pattern "\/" against "/" with FNM_PATHNAME 
>> set, but APR does:
>>
>> 0000000052585e22 apr_fnmatch(".*\//", ".//", 2) = 0, glibc=1
> 
> Do we want to change this behavior?  We must still be careful of the
> special meaning of '/' but we can force a mismatch by dropping the
> logic at line 218-219, which quietly ignores the leading backslash.
> Other tests for \/ must remain.

I would argue to keep our behavior, based on typical shell behavior;

$ ls lib\/.svn

tab completion or pressing enter here both work just fine, and this
should be reflected by our APR_FNM_PATHNAME behavior as well.