From dev-return-24110-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Thu May 12 16:31:52 2011 Return-Path: X-Original-To: apmail-apr-dev-archive@www.apache.org Delivered-To: apmail-apr-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4B9765D55 for ; Thu, 12 May 2011 16:31:52 +0000 (UTC) Received: (qmail 92261 invoked by uid 500); 12 May 2011 16:31:51 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 92201 invoked by uid 500); 12 May 2011 16:31:51 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 92193 invoked by uid 99); 12 May 2011 16:31:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 May 2011 16:31:51 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [173.201.192.104] (HELO p3plsmtpa06-03.prod.phx3.secureserver.net) (173.201.192.104) by apache.org (qpsmtpd/0.29) with SMTP; Thu, 12 May 2011 16:31:44 +0000 Received: (qmail 4911 invoked from network); 12 May 2011 16:31:22 -0000 Received: from unknown (76.252.112.72) by p3plsmtpa06-03.prod.phx3.secureserver.net (173.201.192.104) with ESMTP; 12 May 2011 16:31:22 -0000 Message-ID: <4DCC0B57.4000501@rowe-clan.net> Date: Thu, 12 May 2011 11:31:19 -0500 From: "William A. Rowe Jr." User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: dev@apr.apache.org Subject: Re: svn commit: r1101905 - /apr/apr/trunk/test/testfnmatch.c References: <20110511145134.24066238890A@eris.apache.org> <4DCAAF6E.3050907@rowe-clan.net> <20110512084001.GA4469@redhat.com> <4DCC0A24.8070206@rowe-clan.net> In-Reply-To: <4DCC0A24.8070206@rowe-clan.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/12/2011 11:26 AM, William A. Rowe Jr. wrote: > > I believe what is meant is mismatch + 1; []] should be valid to find ']', only > as the leading character, and a quick test confirms it fails. But the exception > is more optimal if handled ahead of while (**pattern)... fixing shortly. ... which wouldn't handle []-}] properly, for example. Not that it is absolutely required, but is accepted on both linux and bsd. Will fix accordingly, this is a target ripe for goto optimization.