From dev-return-24041-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Mon May 2 16:46:26 2011 Return-Path: X-Original-To: apmail-apr-dev-archive@www.apache.org Delivered-To: apmail-apr-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D6EFE3F19 for ; Mon, 2 May 2011 16:46:26 +0000 (UTC) Received: (qmail 51061 invoked by uid 500); 2 May 2011 16:46:26 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 51001 invoked by uid 500); 2 May 2011 16:46:26 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 50993 invoked by uid 99); 2 May 2011 16:46:26 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 May 2011 16:46:26 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [64.202.165.99] (HELO smtpauth05.prod.mesa1.secureserver.net) (64.202.165.99) by apache.org (qpsmtpd/0.29) with SMTP; Mon, 02 May 2011 16:46:17 +0000 Received: (qmail 20136 invoked from network); 2 May 2011 16:45:55 -0000 Received: from unknown (75.38.194.115) by smtpauth05.prod.mesa1.secureserver.net (64.202.165.99) with ESMTP; 02 May 2011 16:45:54 -0000 Message-ID: <4DBEDFC3.5080405@rowe-clan.net> Date: Mon, 02 May 2011 12:45:55 -0400 From: "William A. Rowe Jr." User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.17) Gecko/20110414 Lightning/1.0b2 Thunderbird/3.1.10 MIME-Version: 1.0 To: dev@apr.apache.org, Stefan Sperling Subject: Re: apr 1.4.3 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On 5/2/2011 8:11 AM, Jeff Trawick wrote: > Anticipated timeline for release: > > * Jeff to review/test wrowe's fnmatch rewrite today (Monday) > * someone else do the same??? Stefan was interested in it. I'm building upon a list of patterns in test/testfnmatch.c designed to tickle bugs, not looking at the code again. I'll commit Bert's root dir and my url path 'case-ignore' patch tonight, and spend just 20 min looking at the apr_file_stat's behavior w.r.t. new win7 softlinks with and without APR_FSTAT_LINK, just to make sure we are on the right page. I like the single announce idea. FYI there are two remaining warnings in apr_fnmatch.c, one is the assignment within conditional that is trivial to fix (it was paren delimited so the compiler shouldn't be complaining anyways), but the other is a fixed loop with no useful break expression, e.g. for (matchptr = pattern, matchlen = 0; 1; ++matchlen) termination conditions all had specific additional processing. If there was a worthwhile alternative to avoid the warning, I didn't see it. If there are any other warnings at -Wall I don't use the same compilers as you had; please share.