apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: svn commit: r1102138 - in /apr/apr/trunk: include/arch/win32/apr_dbg_win32_handles.h include/arch/win32/apr_private.h misc/win32/misc.c
Date Thu, 12 May 2011 00:27:58 GMT
On Wed, May 11, 2011 at 8:02 PM, Jeff Trawick <trawick@gmail.com> wrote:
> On Wed, May 11, 2011 at 7:57 PM, William A. Rowe Jr.
> <wrowe@rowe-clan.net> wrote:
>> On 5/11/2011 6:42 PM, trawick@apache.org wrote:
>>> Author: trawick
>>> Date: Wed May 11 23:42:05 2011
>>> New Revision: 1102138
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1102138&view=rev
>>> Log:
>>> Don't unconditionally include apr_dbg_win32_handles.h
>>> anywhere (misc.c), as it enables special handle debugging
>>> support within APR.
>>
>> That's not right, either.  apr_dbg_log is unconditionally compiled and exported.
>
> Then the proto moves to apr_private.h.

actually, to apr_arch_misc.h...

>
> Working on it...
>
>> The *logging* in any particular module via inclusion of the .h file is conditional.
>
> BTW, when is the last time this was used, other than recent
> inadvertent use?  Other than open.c and maybe pipe.c, does it DTRT?
>



-- 
Born in Roswell... married an alien...

Mime
View raw message