apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: LoadLibrary failures? (Was: RE: MinGW status)
Date Wed, 11 May 2011 21:21:17 GMT
On Wed, May 11, 2011 at 4:44 PM, William A. Rowe Jr.
<wrowe@rowe-clan.net> wrote:
> On 5/11/2011 9:23 AM, Jeff Trawick wrote:
>>>
>>>> Running myapp.exe against libapr-2-0.dll can result in a myapp.exe.###
>>>> droplet that looks like this:
>>>>
>>>> 75B30000 00000001 00001774 LoadLibraryA() misc/win32/misc.c:175
>
> This affects httpd 2.2.18, released.  One per pid each time httpd is launched.
> I am of the mind to remove the offending #include and roll an -R2.msi binary
> package, if nobody much minds.  I'd leave the -win32-src packages unmolested
> unless people feel strongly.

Rolling the binary with the patch, leaving the source alone, and
providing a patch separately seems reasonable.

>
> You added this;
>
> https://svn.apache.org/viewvc/apr/apr/branches/1.4.x/misc/win32/misc.c?r1=1084322&r2=1084323&
>
> which was spawned from;
>
> https://svn.apache.org/viewvc/apr/apr/trunk/misc/win32/misc.c?r1=892177&r2=892176&pathrev=892177
>
> Did you intend to?

Did I intend to?  Yes

/* Declared in include/arch/win32/apr_dbg_win32_handles.h
 */
APR_DECLARE_NONSTD(HANDLE) apr_dbg_log(char* fn, HANDLE ha, char* fl, int ln,
                                       int nh, /* HANDLE hv, char *dsc */...)

Should I have meant to?  Apparently Not!!  I read the comment and not
the header file.

I'll suggest a better fix separately.

Mime
View raw message