Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (nike.apache.org: 74.208.4.195 is neither permitted nor
 denied by domain of SRS0=MlRd=WE=bellatlantic.net=donovant@srs.perfora.net)
Message-ID: <4D796DA7.1020906@bellatlantic.net>
Date: Thu, 10 Mar 2011 19:32:39 -0500
From: Tom Donovan <donovant@bellatlantic.net>
Reply-To: Tom.Donovan@acm.org
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US;
 rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9
MIME-Version: 1.0
To: dev@apr.apache.org
Subject: Re: svn commit: r1078507 - /apr/apr/trunk/dbd/apr_dbd_odbc.c
References: <20110306163446.EC605238899C@eris.apache.org>
 <AANLkTinBnk3p5QKJM0=j=-mDfxqda3974-QimoCCYie_@mail.gmail.com>
 <4D77CCCA.6020601@rowe-clan.net>
In-Reply-To: <4D77CCCA.6020601@rowe-clan.net>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

On 3/9/2011 1:54 PM, William A. Rowe Jr. wrote:
> On 3/9/2011 12:40 PM, Jeff Trawick wrote:
>>
>> The original code was a bit disturbing because of the indentation:
>>
>>      /* mark all the columns as needing SQLGetData unless they are bound  */
>>      for (c = 0; c<  res->ncols; c++) {
>>          if (res->colstate[c] != COL_BOUND)
>>              res->colstate[c] = COL_AVAIL;
>>              /* some drivers do not null-term zero-len CHAR data */
>>              if (res->colptrs[c] )
>>                  * (char *) res->colptrs[c] = 0;
>>      }
>>
>>  From the indentation, it looks like the second 'if' is part of a block
>> starting with res->colstate[c] = COL_AVAIL.
>
> Someone perhaps had a bit too much Python on their brain?  :)
>
>> The behavior stayed the same across the reformat, and I can't confirm
>> that the original code was broken, but still...
>
> Jumping back across whitespace changes, this originates at Tom's original
> checkin... Tom, can you verify if the behavior is correct and fix the
> indentation, or fix the code if the scope isn't correct?
>
Done.  Change 1080403.  The behavior was correct, the indenting wasn't.

Sorry about the disturbing indentation.

-tom-