From dev-return-23860-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Thu Mar 24 14:13:21 2011 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 68769 invoked from network); 24 Mar 2011 14:13:20 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 24 Mar 2011 14:13:20 -0000 Received: (qmail 35872 invoked by uid 500); 24 Mar 2011 14:13:20 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 35796 invoked by uid 500); 24 Mar 2011 14:13:19 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 35788 invoked by uid 99); 24 Mar 2011 14:13:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Mar 2011 14:13:19 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of trawick@gmail.com designates 209.85.214.50 as permitted sender) Received: from [209.85.214.50] (HELO mail-bw0-f50.google.com) (209.85.214.50) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Mar 2011 14:13:13 +0000 Received: by bwz2 with SMTP id 2so96951bwz.37 for ; Thu, 24 Mar 2011 07:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:date:message-id:subject:from:to :content-type; bh=9qybYLhqYVCVekqueFo1adxfzM43QG4iwgkUvJ1xoL4=; b=kCU6ewqzAC3rwKwI4sZwEF5Ai029FL9CeWOgqt4IdY/1G5ZgPu2sjzaD+vE5DS//I+ KVYdl1XldnSb54YVnFWmdh+Swzz+qy3R1i1a8+uVuxStOUZ3KaBu1/R9wt69UC7hBO/a rmobNV8B58F6mmzYzr70dLjTbDVJJmsUN6gaA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=ePnVPeBKCgUi1Q7yUewuft9Yz085iqX2HXNy0djJT9Y+VBHPAleTdfAMAy7/19HxV2 sAPz84ugUT5X8gnfVvVwz6XnFYIVTvH85L0JrHwbuO/TCRrNOYuaQHSkxwTXdRLcxDFF LGGcPiwJFNX9JbN4kYxYNLqdTbIhvykCUtdR4= MIME-Version: 1.0 Received: by 10.204.15.130 with SMTP id k2mr7712395bka.95.1300975971961; Thu, 24 Mar 2011 07:12:51 -0700 (PDT) Received: by 10.204.157.17 with HTTP; Thu, 24 Mar 2011 07:12:51 -0700 (PDT) Date: Thu, 24 Mar 2011 10:12:51 -0400 Message-ID: Subject: pollset/pollcb questions From: Jeff Trawick To: APR Developer List Content-Type: text/plain; charset=ISO-8859-1 Dear Lazyweb, I noticed that pollset_create is missing this particular checking for NODEFAULT, which is present in pollcb_create. Do you know why? Index: poll/unix/pollset.c =================================================================== --- poll/unix/pollset.c (revision 1084961) +++ poll/unix/pollset.c (working copy) @@ -253,6 +253,11 @@ if (method == pollset_default_method) { return rv; } + + if ((flags & APR_POLLSET_NODEFAULT) == APR_POLLSET_NODEFAULT) { + return rv; + } + provider = pollset_provider(pollset_default_method); if (!provider) { return APR_ENOTIMPL; I noticed that the poll() flavor of pollcb_create returns not-implemented for threaded builds. Why isn't this instead a check for the APR_POLLSET_THREADSAFE requirement? Index: poll/unix/poll.c =================================================================== --- poll/unix/poll.c (revision 1084961) +++ poll/unix/poll.c (working copy) @@ -304,9 +304,9 @@ apr_pool_t *p, apr_uint32_t flags) { -#if APR_HAS_THREADS - return APR_ENOTIMPL; -#endif + if (flags & APR_POLLSET_THREADSAFE) { + return APR_ENOTIMPL; + } pollcb->fd = -1; #ifdef WIN32