apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject pollset/pollcb questions
Date Thu, 24 Mar 2011 14:12:51 GMT
Dear Lazyweb,

I noticed that pollset_create is missing this particular checking for
NODEFAULT, which is present in pollcb_create.  Do you know why?

Index: poll/unix/pollset.c
===================================================================
--- poll/unix/pollset.c	(revision 1084961)
+++ poll/unix/pollset.c	(working copy)
@@ -253,6 +253,11 @@
         if (method == pollset_default_method) {
             return rv;
         }
+
+        if ((flags & APR_POLLSET_NODEFAULT) == APR_POLLSET_NODEFAULT) {
+            return rv;
+        }
+
         provider = pollset_provider(pollset_default_method);
         if (!provider) {
             return APR_ENOTIMPL;

I noticed that the poll() flavor of pollcb_create returns
not-implemented for threaded builds.  Why isn't this instead a check
for the APR_POLLSET_THREADSAFE requirement?

Index: poll/unix/poll.c
===================================================================
--- poll/unix/poll.c	(revision 1084961)
+++ poll/unix/poll.c	(working copy)
@@ -304,9 +304,9 @@
                                        apr_pool_t *p,
                                        apr_uint32_t flags)
 {
-#if APR_HAS_THREADS
-  return APR_ENOTIMPL;
-#endif
+    if (flags & APR_POLLSET_THREADSAFE) {
+        return APR_ENOTIMPL;
+    }

     pollcb->fd = -1;
 #ifdef WIN32

Mime
View raw message