apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guenter Knauf <fua...@apache.org>
Subject Re: svn commit: r1086790 - /apr/apr/trunk/xml/apr_xml_internal.h
Date Tue, 29 Mar 2011 22:52:35 GMT
Hi Jeff,
Am 30.03.2011 00:29, schrieb trawick@apache.org:
> Author: trawick
> Date: Tue Mar 29 22:29:05 2011
> New Revision: 1086790
>
> URL: http://svn.apache.org/viewvc?rev=1086790&view=rev
> Log:
> fix linkage of apr_parser_create_ex() on Windows
>
> Submitted by: Carlo Bramini<carlo.bramix libero.it>
> PR:           tiny part of 46175
>
> Modified:
>      apr/apr/trunk/xml/apr_xml_internal.h
>
> Modified: apr/apr/trunk/xml/apr_xml_internal.h
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/xml/apr_xml_internal.h?rev=1086790&r1=1086789&r2=1086790&view=diff
> ==============================================================================
> --- apr/apr/trunk/xml/apr_xml_internal.h (original)
> +++ apr/apr/trunk/xml/apr_xml_internal.h Tue Mar 29 22:29:05 2011
> @@ -43,8 +43,6 @@ struct apr_xml_parser {
>       XMLParserImpl *impl;
>   };
>
> -
> -
> -apr_xml_parser *apr_xml_parser_create_ex(apr_pool_t*, void*, void*, void*);
> +APR_DECLARE(apr_xml_parser *) apr_xml_parser_create_ex(apr_pool_t*, void*, void*, void*);
>
>   #endif
are you really sure this is the right thing? /me doubt ...
1. its in an internal header - if we want to expoert that function then 
it should be moved to a public header
2. if you look into apr_xml.c you can find:
APR_DECLARE(apr_xml_parser *) apr_xml_parser_create(apr_pool_t *pool)
{
     return apr_xml_parser_create_ex(pool, &start_handler, &end_handler, 
&cdata_handler);
}

so why should something directly link against apr_xml_parser_create_ex() ?

Gün.



Mime
View raw message