Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 12283 invoked from network); 12 Feb 2011 22:00:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 12 Feb 2011 22:00:45 -0000 Received: (qmail 68291 invoked by uid 500); 12 Feb 2011 22:00:45 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 68065 invoked by uid 500); 12 Feb 2011 22:00:44 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 68057 invoked by uid 99); 12 Feb 2011 22:00:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Feb 2011 22:00:44 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of minfrin@sharp.fm designates 72.32.122.20 as permitted sender) Received: from [72.32.122.20] (HELO chandler.sharp.fm) (72.32.122.20) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 12 Feb 2011 22:00:36 +0000 Received: from chandler.sharp.fm (localhost [127.0.0.1]) by chandler.sharp.fm (Postfix) with ESMTP id E55C5508036; Sat, 12 Feb 2011 16:00:15 -0600 (CST) Received: from [10.0.0.251] (87-194-125-18.bethere.co.uk [87.194.125.18]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client did not present a certificate) (Authenticated sender: minfrin@sharp.fm) by chandler.sharp.fm (Postfix) with ESMTP id 6ED54508033; Sat, 12 Feb 2011 16:00:15 -0600 (CST) Cc: APR Developer List Message-Id: From: Graham Leggett To: "Roy T. Fielding" In-Reply-To: Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: Junk characters on the end of dates Date: Sun, 13 Feb 2011 00:00:13 +0200 References: <6D79463C-BD97-4CAE-83DD-7FCE21156C91@SHARP.FM> X-Mailer: Apple Mail (2.936) X-Virus-Scanned: ClamAV using ClamSMTP On 12 Feb 2011, at 10:23 PM, Roy T. Fielding wrote: >> As part of https://issues.apache.org/bugzilla/show_bug.cgi? >> id=16521, we currently accept dates that are trailed by extra >> characters without complaining. The following patch marks such >> dates as APR_DATE_BAD. Does this patch make sense? > > No, we don't complain because some clients send dates with extra > junk on the end, like Netscape did with the ugly ;len=size crap > on the end of an IMS field. That was my gut feel, which is why I asked - if we've managed to get as far as gleaning a date from the string, that should be good enough. I'll mark that part as wontfix. Regards, Graham --