Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 1421 invoked from network); 11 Dec 2010 19:29:36 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 11 Dec 2010 19:29:36 -0000 Received: (qmail 56899 invoked by uid 500); 11 Dec 2010 19:29:35 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 56785 invoked by uid 500); 11 Dec 2010 19:29:34 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 56777 invoked by uid 99); 11 Dec 2010 19:29:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Dec 2010 19:29:34 +0000 X-ASF-Spam-Status: No, hits=0.7 required=10.0 tests=RCVD_IN_DNSWL_NONE,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: 76.96.27.243 is neither permitted nor denied by domain of jim@jagunet.com) Received: from [76.96.27.243] (HELO qmta13.emeryville.ca.mail.comcast.net) (76.96.27.243) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Dec 2010 19:29:24 +0000 Received: from omta23.emeryville.ca.mail.comcast.net ([76.96.30.90]) by qmta13.emeryville.ca.mail.comcast.net with comcast id htFM1f0021wfjNsADvV22B; Sat, 11 Dec 2010 19:29:02 +0000 Received: from [192.168.199.10] ([69.251.84.64]) by omta23.emeryville.ca.mail.comcast.net with comcast id hvV01f0081PGofZ8jvV1n8; Sat, 11 Dec 2010 19:29:02 +0000 Subject: Re: svn commit: r1044440 - /apr/apr/trunk/file_io/unix/seek.c Mime-Version: 1.0 (Apple Message framework v1082) Content-Type: text/plain; charset=us-ascii From: Jim Jagielski In-Reply-To: <4D02610B.9090904@apache.org> Date: Sat, 11 Dec 2010 14:29:00 -0500 Cc: commits@apr.apache.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20101210170650.2EEC7238897A@eris.apache.org> <4D02610B.9090904@apache.org> To: dev@apr.apache.org X-Mailer: Apple Mail (2.1082) X-Virus-Checked: Checked by ClamAV on apache.org On Dec 10, 2010, at 12:19 PM, Mladen Turk wrote: > On 12/10/2010 06:06 PM, mturk@apache.org wrote: >> Author: mturk >> Date: Fri Dec 10 17:06:49 2010 >> New Revision: 1044440 >>=20 >> URL: http://svn.apache.org/viewvc?rev=3D1044440&view=3Drev >> Log: >> Fix file_trunc for buffered files. Make sure the write buffer is = flushed before truncate call >>=20 >> Modified: >> apr/apr/trunk/file_io/unix/seek.c >>=20 >=20 >=20 > Any problem with porting that to the stable branches? > In case of buffered files apr_file_trunc just doesn't > work if there is something in the write buffer below > the truncation point. >=20 No prob from my PoV... +1