Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <4D0A86EE.5090006@rowe-clan.net>
Date: Thu, 16 Dec 2010 15:38:54 -0600
From: "William A. Rowe Jr." <wrowe@rowe-clan.net>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US;
 rv:1.9.2.13) Gecko/20101207 Lightning/1.0b2 Thunderbird/3.1.7
MIME-Version: 1.0
To: Jim Jagielski <jim@apache.org>
CC: dev@apr.apache.org
Subject: Re: [PATCH] Re: [PATCH] %lld support in apr_snprintf()
References: <37818C6C-E90A-4DA4-A57B-91E8A4612077@temme.net>
 <4CD3066E.7010402@rowe-clan.net>
 <1D4C0A5A-5966-41A9-AB53-F3963CD59E80@temme.net>
 <AANLkTikZe33rW-_PP_be=mDW9JMtu+jtQe-KztwxDh0v@mail.gmail.com>
 <AANLkTi=fwXYhBVE_gvwY2KiFT3xv36GG=_Vq_gmuW+=J@mail.gmail.com>
 <1DAE160F-A799-4E68-85F4-4AA7477EC3B8@nasa.gov>
 <AANLkTin7_-Fw2zv87LQdrVZZLkO_S7gXTOk-rX0rkexa@mail.gmail.com>
 <2AD67559-8ADA-4E9A-9DBF-3DF913C0D813@jaguNET.com>
 <yuahbeewutm.fsf@kabuki.mynet>
 <30554DCD-35E8-45E6-9A46-60E9C077A6DE@jaguNET.com>
 <1AEDF293-893D-4A61-9896-0FD06BA89C83@jaguNET.com>
 <1C04627C-2669-4257-90DC-157EAE192999@jaguNET.com>
 <4D0A7A40.7070202@rowe-clan.net>
 <3651BDBF-D129-4414-B4B0-E42DB3DE4C32@apache.org>
In-Reply-To: <3651BDBF-D129-4414-B4B0-E42DB3DE4C32@apache.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 12/16/2010 3:36 PM, Jim Jagielski wrote:
>>
>>> +    # where int and long are the same size. Use the longest
>>> +    # type that fits
>>> +    if test "$ac_cv_sizeof_off_t" = "$ac_cv_sizeof_long_long"; then
>>> +        off_t_fmt='#define APR_OFF_T_FMT APR_INT64_T_FMT'
>>> +        off_t_strfn='apr_strtoi64'
>>
>> This is bad, no?  We don't know that long_long and off_t aren't 128 bytes.
>> It seems better to use the explicit "ll" format here instead of the value
>> reserved for 64 bit ints.
>>
> 
> All I did was re-arrange the order...

Not arguing, suggesting that the thorough test is either to compare the
ac_cv_sizeof_off_t to 8, and then use APR_OFF_T_FMT, or failing that, instead
see if it matches long_long, and use an explicit "ll".

WDYT?