Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: local policy)
Subject: Re: [PATCH] %lld support in apr_snprintf()
MIME-Version: 1.0 (Apple Message framework v1081)
Content-Type: text/plain; charset="us-ascii"
From: Chris Knight <Christopher.D.Knight@nasa.gov>
In-Reply-To: <AANLkTi=fwXYhBVE_gvwY2KiFT3xv36GG=_Vq_gmuW+=J@mail.gmail.com>
Date: Sun, 7 Nov 2010 15:51:39 -0800
CC: APR Developer List <dev@apr.apache.org>
Content-Transfer-Encoding: quoted-printable
Message-ID: <1DAE160F-A799-4E68-85F4-4AA7477EC3B8@nasa.gov>
References: <37818C6C-E90A-4DA4-A57B-91E8A4612077@temme.net>
 <4CD3066E.7010402@rowe-clan.net>
 <1D4C0A5A-5966-41A9-AB53-F3963CD59E80@temme.net>
 <AANLkTikZe33rW-_PP_be=mDW9JMtu+jtQe-KztwxDh0v@mail.gmail.com>
 <AANLkTi=fwXYhBVE_gvwY2KiFT3xv36GG=_Vq_gmuW+=J@mail.gmail.com>
To: Jeff Trawick <trawick@gmail.com>

Exactly, the problem only appears on 64-bit Snow Leopard. See my patch =
in Bugzilla, which I've verified. (Unsure if the below would also work, =
been a long time since I diagnosed.)

On Nov 7, 2010, at 3:36 PM, Jeff Trawick wrote:

> On Sun, Nov 7, 2010 at 5:18 PM, Jeff Trawick <trawick@gmail.com> =
wrote:
>> On Sun, Nov 7, 2010 at 5:07 PM, Sander Temme <sander@temme.net> =
wrote:
>>>=20
>>> On Nov 4, 2010, at 12:15 PM, William A. Rowe Jr. wrote:
>>>=20
>>>> Looks good here.
>>>=20
>>> If folks find this unproblematic, can someone please commit it?  I =
don't have karma here.
>>>=20
>>> Thanks,
>>=20
>> looks fine to me; starting to try it out now
>=20
> The patch is apparently not needed to make %lld work in 32-bit mode on
> Leopard since APR_INT64_T_FMT is %lld.
> It didn't make %lld work in 64-bit mode.
>=20
> What are the cases where you see this help out?
>=20
> I guess you're on Snow Leopard?
>=20
> Here's what I tried in 64-bit mode:
>=20
> Index: strings/apr_snprintf.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- strings/apr_snprintf.c	(revision 1032408)
> +++ strings/apr_snprintf.c	(working copy)
> @@ -832,6 +832,11 @@
>             else if (*fmt =3D=3D 'l') {
>                 var_type =3D IS_LONG;
>                 fmt++;
> +                /* Catch the %lld type modifier for long long and its =
ilk */
> +                if (*fmt =3D=3D 'l') {
> +                    var_type =3D IS_QUAD;
> +                    fmt++;
> +                }
>             }
>             else if (*fmt =3D=3D 'h') {
>                 var_type =3D IS_SHORT;
>=20
>=20
> ndex: testfmt.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- testfmt.c	(revision 1032408)
> +++ testfmt.c	(working copy)
> @@ -126,6 +126,9 @@
>=20
>     apr_snprintf(buf, sizeof buf, "%" APR_INT64_T_FMT, ibig);
>     ABTS_STR_EQUAL(tc, "-314159265358979323", buf);
> +
> +    apr_snprintf(buf, sizeof buf, "%lld", ibig);
> +    ABTS_STR_EQUAL(tc, "-314159265358979323", buf);
> }
>=20
> static void error_fmt(abts_case *tc, void *data)
>=20
> ./testall -v testfmt
> testfmt             : /Line 131: expected <-314159265358979323>, but =
saw <%ld>
> FAILED 1 of 10
> Failed Tests   		Total	Fail	Failed %
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D
> testfmt        		   10	   1	 10.00%