apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r1002584 [1/5] - in /apr/apr-util/branches/1.5.x/xml/expat: ./ conftools/ lib/ win32/
Date Wed, 29 Sep 2010 16:32:47 GMT
On 29.09.2010 13:52, jorton@apache.org wrote:
> Author: jorton
> Date: Wed Sep 29 11:52:55 2010
> New Revision: 1002584
>
> URL: http://svn.apache.org/viewvc?rev=1002584&view=rev
> Log:
> * xml/expat: Merge changes from expat 1.95.2 ->  1.95.7.
...
> Modified:
...
>      apr/apr-util/branches/1.5.x/xml/expat/buildconf.sh


> Modified: apr/apr-util/branches/1.5.x/xml/expat/buildconf.sh
> URL: http://svn.apache.org/viewvc/apr/apr-util/branches/1.5.x/xml/expat/buildconf.sh?rev=1002584&r1=1002583&r2=1002584&view=diff
> ==============================================================================
> --- apr/apr-util/branches/1.5.x/xml/expat/buildconf.sh (original)
> +++ apr/apr-util/branches/1.5.x/xml/expat/buildconf.sh Wed Sep 29 11:52:55 2010
> @@ -25,7 +25,7 @@ echo "Copying libtool helper files ..."
>   (cd conftools ; rm -f ltconfig ltmain.sh)
>   rm -rf aclocal.m4 libtool.m4 ltsugar.m4 autom4te*.cache
>
> -$libtoolize --copy --automake
> +$libtoolize --copy --automake --force

Do we actually want that? Now buildconf.sh overrides our svn provided 
and maintained config.guess and config.sub with the ones installed with 
libtool, which are often pretty outdated. That might influence 
negatively the ability to build expat on modern systems.

My impression is, that those are the only preexisting files, so omitting 
"--force" will correctly install all other files, at least if we always 
them up during previous buildconf runs.

Second question: where do we want the libtool m4 files and aclocal.m4 
during expat buildconf to be located: in the expat top directory or in 
conftools? I had the impression you want them now in conftools, but then 
there are some more fixes in the expat buildconf necessary, at least for 
libtool 1. I have them ready but want to make sure I understand your 
intention.

Regards,

Rainer

Mime
View raw message