apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Carlo Marcelo Arenas Belon <care...@sajinet.com.pe>
Subject undefined behaviour from apr_pollset_create
Date Wed, 04 Aug 2010 14:17:04 GMT

is the status of the pollset pointer in apr_pollset_create when size = 0
undefined or just undocumented?

apr_pollset_create in apr 0.9 used to keep that pointer unchanged (NULL)
for that case and by looking at the code/behaviour from newer versions
it would seem that it gets allocated an apr_pollset_t* always, resulting
on an application bug, where an infinite loop was created while polling
repeatedly and empty pollset.

making that a NULL pointer was a sideffect of asking for apr_palloc
for a 0 size in 0.9, and since the logic has changed since then size
is no longer involved on the creation of that pointer, but I am not
sure if that was indeed intentional.

either way, documentation is mute about this case, but is this something
that would/could be fixed?, or should be at least mentioned as undefined
considering the change on behaviour between versions?


View raw message