Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 85558 invoked from network); 28 Jul 2010 20:38:05 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 28 Jul 2010 20:38:05 -0000 Received: (qmail 12075 invoked by uid 500); 28 Jul 2010 20:38:05 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 11945 invoked by uid 500); 28 Jul 2010 20:38:04 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 11938 invoked by uid 99); 28 Jul 2010 20:38:04 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jul 2010 20:38:04 +0000 X-ASF-Spam-Status: No, hits=-2.3 required=10.0 tests=RCVD_IN_DNSWL_MED,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [188.40.99.202] (HELO eru.sfritsch.de) (188.40.99.202) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 28 Jul 2010 20:37:57 +0000 Received: from stf (helo=localhost) by eru.sfritsch.de with local-esmtp (Exim 4.69) (envelope-from ) id 1OeDNg-0000wC-Vf for dev@apr.apache.org; Wed, 28 Jul 2010 22:37:37 +0200 Date: Wed, 28 Jul 2010 22:37:36 +0200 (CEST) From: Stefan Fritsch To: dev@apr.apache.org Subject: Re: svn commit: r979891 - in /apr/apr/trunk: build/ dbd/ dbm/ file_io/netware/ file_io/os2/ file_io/unix/ file_io/win32/ memory/unix/ threadproc/beos/ threadproc/unix/ In-Reply-To: <4C507A7D.1060805@apache.org> Message-ID: References: <20100727220946.35C9B2388993@eris.apache.org> <4C507A7D.1060805@apache.org> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Virus-Checked: Checked by ClamAV on apache.org On Wed, 28 Jul 2010, Ruediger Pluem wrote: > On 07/28/2010 12:09 AM, sf@apache.org wrote: >> Author: sf >> Date: Tue Jul 27 22:09:45 2010 >> New Revision: 979891 >> Modified: apr/apr/trunk/dbm/apr_dbm_sdbm.c >> URL: http://svn.apache.org/viewvc/apr/apr/trunk/dbm/apr_dbm_sdbm.c?rev=979891&r1=979890&r2=979891&view=diff >> ============================================================================== >> --- apr/apr/trunk/dbm/apr_dbm_sdbm.c (original) >> +++ apr/apr/trunk/dbm/apr_dbm_sdbm.c Tue Jul 27 22:09:45 2010 >> @@ -193,7 +193,7 @@ static apr_status_t vt_sdbm_nextkey(apr_ >> pkey->dsize = rd.dsize; >> >> /* store any error info into DBM, and return a status code. */ >> - return set_error(dbm, APR_SUCCESS); >> + return set_error(dbm, rv); > > This breaks the testdbm test of apr. Sorry, reverted in r980197 for now. This discards any error from getnext() in sdbm.c, including those from the chkpage consistency check. But ATM, I am not sure how to fix this correctly.