Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of gstein@gmail.com designates
 209.85.160.178 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=g3GOcnruC6pXR8cqARMs+JVw0jkdLy8GGpVMM0zGG21JmIlbNTiUDwB7b0GXcMjbbv
         xyzmnXCInv6MRdqAXkVbr9IhIPAQGnVS6wLQIS64GIWtAMqWvFjPfl2SA/zIHWL+YB6L
         zeCJtzVlsOwlrGDu32+204w1tQkgOsW12XbVo=
MIME-Version: 1.0
In-Reply-To: <001701cb1c3f$a9c1aa30$fd44fe90$@nl>
References: <001701cb1c3f$a9c1aa30$fd44fe90$@nl>
Date: Mon, 5 Jul 2010 15:38:27 -0400
Message-ID: <AANLkTil8Z6X2P0XFcsHM7PBvnwlw3YVqA6O-e2zEBFzd@mail.gmail.com>
Subject: Re: [Patch] apr_filepath_merge() on "c:path" fails consistently on
	Windows if the current directory is "c:/windows" instead of "C:/Windows"
From: Greg Stein <gstein@gmail.com>
To: Bert Huijben <bert@qqmail.nl>
Cc: dev@apr.apache.org, "William A. Rowe Jr." <wrowe@rowe-clan.net>,
	Ivan Zhakov <ivan@visualsvn.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Applied in r960665 to trunk.

Backports will be needed before future branch releases (unsure what
the schedule is for that).

Thanks,
-g

On Mon, Jul 5, 2010 at 08:43, Bert Huijben <bert@qqmail.nl> wrote:
> =A0 =A0 =A0 =A0Hi,
>
> As mailed in November 2009 [1], simple apr_filepath_merge() calls on path=
s
> like "C:/Windows" fail for users that use a shell that turns their active
> directory in a "c:/users/bert" style instead of the more common
> "C:/users/bert" (note the lower case 'C').
>
> The current APR code just assumes that drive letters returned by the Wind=
ows
> current path functions are always uppercase, which is not the case. This
> issue is reported every few months on different Subversion mailinglists a=
nd
> probably seen much more often by users that can't explain any of this.
>
> The patch attached to this mail removes the assumption that the drive
> letters must always be uppercase and adds a test which shows the error
> behavior. Easier ways to reproduce are adding a program shortcut with a
> lower case letter in the 'Start In' box, using CygWin or using 'CD /D
> c:\windows' in a dos prompt.
> (See also dirent_uri-tests.exe 36 in Subversion)
>
>
> I'm willing to work on more patches to improve APR and especially APR's
> performance on Windows, but if even this most important patch for me (and
> other Windows Subversion users) takes more than half a year to apply even
> with periodic pinging (some on private@), I can probably better spend my
> time starting my own APR patches for Windows project.
>
>
> For other long delayed Windows specific patches from me and others see [2=
]
> and [3] (but these didn't receive the same amount of review as [1]).
>
> =A0 =A0 =A0 =A0Bert
>
>
> [1] http://marc.info/?t=3D125737717900001&r=3D1&w=3D3
> [2] http://marc.info/?t=3D127143172200001&r=3D1&w=3D2
> [3] http://marc.info/?l=3Dapr-dev&m=3D127219937825412
>
>