apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r979891 - in /apr/apr/trunk: build/ dbd/ dbm/ file_io/netware/ file_io/os2/ file_io/unix/ file_io/win32/ memory/unix/ threadproc/beos/ threadproc/unix/
Date Wed, 28 Jul 2010 18:44:13 GMT


On 07/28/2010 12:09 AM, sf@apache.org wrote:
> Author: sf
> Date: Tue Jul 27 22:09:45 2010
> New Revision: 979891
> 
> URL: http://svn.apache.org/viewvc?rev=979891&view=rev
> Log:
> Fix various issues found by cppcheck
> - error handling issues
> - use of uninitialized data
> - null pointer dereference
> - unused variables
> - memory/fd leaks
> - broken code in threadproc/beos/proc.c
> 
> Modified:
>     apr/apr/trunk/build/aplibtool.c
>     apr/apr/trunk/build/jlibtool.c
>     apr/apr/trunk/dbd/apr_dbd_oracle.c
>     apr/apr/trunk/dbm/apr_dbm_sdbm.c
>     apr/apr/trunk/file_io/netware/pipe.c
>     apr/apr/trunk/file_io/os2/open.c
>     apr/apr/trunk/file_io/unix/open.c
>     apr/apr/trunk/file_io/win32/open.c
>     apr/apr/trunk/memory/unix/apr_pools.c
>     apr/apr/trunk/threadproc/beos/proc.c
>     apr/apr/trunk/threadproc/unix/proc.c
>     apr/apr/trunk/threadproc/unix/procsup.c
> 

> Modified: apr/apr/trunk/dbm/apr_dbm_sdbm.c
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/dbm/apr_dbm_sdbm.c?rev=979891&r1=979890&r2=979891&view=diff
> ==============================================================================
> --- apr/apr/trunk/dbm/apr_dbm_sdbm.c (original)
> +++ apr/apr/trunk/dbm/apr_dbm_sdbm.c Tue Jul 27 22:09:45 2010
> @@ -193,7 +193,7 @@ static apr_status_t vt_sdbm_nextkey(apr_
>      pkey->dsize = rd.dsize;
>  
>      /* store any error info into DBM, and return a status code. */
> -    return set_error(dbm, APR_SUCCESS);
> +    return set_error(dbm, rv);

This breaks the testdbm test of apr.

Regards

RĂ¼diger


Mime
View raw message