apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ivan Zhakov <i...@visualsvn.com>
Subject Re: Why does apr_file_read() with !APR_XTHREAD use mutexes on Windows
Date Mon, 21 Jun 2010 08:09:32 GMT
On Sun, Jun 6, 2010 at 15:23, Bert Huijben <bert@qqmail.nl> wrote:
>> 2 core CPU
>> =========
>> unpatched:   217  (time ticks)
>> patched :      92    (time ticks)
>>
>> Performance improvement: 57%
>>
>> Any chance to get this committed to trunk and backport to 1.3.x?
>
> This patch looks ok for the cases used by Subversion, but it doesn't ensure that files
> in append mode still use the mutex(/critical section).
>
I've other patch to implement atomic append on Windows using
overlapped I/O and FILE_APPEND_DATA without using mutexes. I think
it's different issue that can be fixed separately.


-- 
Ivan Zhakov
VisualSVN Team

Mime
View raw message