Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 52738 invoked from network); 20 May 2010 15:12:23 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 20 May 2010 15:12:23 -0000 Received: (qmail 36587 invoked by uid 500); 20 May 2010 15:12:23 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 36520 invoked by uid 500); 20 May 2010 15:12:22 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 36513 invoked by uid 99); 20 May 2010 15:12:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 May 2010 15:12:22 +0000 X-ASF-Spam-Status: No, hits=-0.4 required=10.0 tests=AWL,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of trawick@gmail.com designates 209.85.217.226 as permitted sender) Received: from [209.85.217.226] (HELO mail-gx0-f226.google.com) (209.85.217.226) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 20 May 2010 15:12:16 +0000 Received: by gxk26 with SMTP id 26so3781374gxk.13 for ; Thu, 20 May 2010 08:11:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=h5QEBrU1Gagpg8FPJAEwhLUiT02nhnqHm/Ma97vd2aA=; b=xNlZ0OZxdEkjtw2rtRhoRt74WkTObX2/IBLMvNb/i7E9XXLVyk8nVrHcgTgiLUc9VT pFKLzJH3CWYQjIq5kERW6TbianVEBasNuITBSzgA4Kz8kQ8MiFNvngejRhffVyYGoYK1 frmW795h5tJCCYnP5qgI3IL6eIdDitJDRGmWM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=sqy7ALIpm3PSQXmEi47IMN7m2UDNd2yfXU/wDFjS++ZPPXdZc/Xuy6B8vZSbzjtTFh NgG4Cxs+dU+8M5PzGiwCaPrXiT2fnLK5EljeOfCGv2/JSCqq4QiD1Qrl+6ILDx2Z6ZR0 fCc7CzkcvNMk8HQGxQ/n3mqCO86aX57zrOVoU= MIME-Version: 1.0 Received: by 10.101.5.25 with SMTP id h25mr291180ani.6.1274368315171; Thu, 20 May 2010 08:11:55 -0700 (PDT) Received: by 10.101.66.20 with HTTP; Thu, 20 May 2010 08:11:55 -0700 (PDT) In-Reply-To: <20100309144223.9ECC0238897A@eris.apache.org> References: <20100309144223.9ECC0238897A@eris.apache.org> Date: Thu, 20 May 2010 11:11:55 -0400 Message-ID: Subject: Re: svn commit: r920897 - /apr/apr/trunk/file_io/win32/open.c From: Jeff Trawick To: dev@apr.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Tue, Mar 9, 2010 at 10:42 AM, wrote: > Author: jfclere > Date: Tue Mar =A09 14:42:23 2010 > New Revision: 920897 > > URL: http://svn.apache.org/viewvc?rev=3D920897&view=3Drev > Log: > typos? Otherwise it won't compile. > > Modified: > =A0 =A0apr/apr/trunk/file_io/win32/open.c > > Modified: apr/apr/trunk/file_io/win32/open.c > URL: http://svn.apache.org/viewvc/apr/apr/trunk/file_io/win32/open.c?rev= =3D920897&r1=3D920896&r2=3D920897&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- apr/apr/trunk/file_io/win32/open.c (original) > +++ apr/apr/trunk/file_io/win32/open.c Tue Mar =A09 14:42:23 2010 > @@ -610,8 +610,8 @@ APR_DECLARE(apr_status_t) apr_file_link( > =A0#endif > =A0#if APR_HAS_ANSI_FS > =A0 =A0 ELSE_WIN_OS_IS_ANSI { > - =A0 =A0 =A0 =A0if (!CreateHardLinkA(wto_path, wfrom_path)) > - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return apr_get_os_error() > + =A0 =A0 =A0 =A0if (!CreateHardLinkA(to_path, from_path, NULL)) > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return apr_get_os_error(); lame question months late: What is the compilation environment in which this ANSI_FS code is compiled -- i.e., WINNT is not defined? Old OS or old MS SDK or ??? #if defined(_WIN32_WCE) || defined(WINNT) #define APR_HAS_ANSI_FS 0 #else #define APR_HAS_ANSI_FS 1 #endif