apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: [patch]: ./buildconf as not root
Date Thu, 27 May 2010 14:12:10 GMT
On Mon, May 24, 2010 at 4:41 PM, Philip M. Gollucci
<pgollucci@p6m7g8.com> wrote:
> You get prompted in fbsd to overide -r--r--r perms for the rm without this.
>  We do this in the devel/apr* ports so it breaks automatic builds.
>
> I'd like to propose this for branches/1.4.x as well.
>
> This has been sitting in the port for like 6 months now.
>
> svn diff buildconf
> Index: buildconf
> ===================================================================
> --- buildconf   (revision 947518)
> +++ buildconf   (working copy)
> @@ -69,6 +69,7 @@
>   fi
>   # Do we need this anymore?
>   echo "buildconf: Using libtool.m4 at ${ltfile}."
> +  chmod 644 build/libtool.m4

for minimal permissions hacking, why not "chmod u+w" ?

>   cat $ltfile | sed -e 's/LIBTOOL=\(.*\)top_build/LIBTOOL=\1apr_build/' >
> build/libtool.m4
>  fi
>  if test "$1" = "2"; then
> @@ -76,6 +77,7 @@
>   # Wouldn't it just be better to define top_builddir??
>   mv build/libtool.m4 build/libtool.m4.$$
>   cat build/libtool.m4.$$ | sed -e
> 's/LIBTOOL=\(.*\)top_build/LIBTOOL=\1apr_build/' > build/libtool.m4
> +  chmod 644 build/libtool.m4.$$
>   rm build/libtool.m4.$$

for minimal permissions hacking, why not "rm -f" ?

Mime
View raw message