Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: domain of hyrum_wright@mail.utexas.edu
 designates 146.6.25.7 as permitted sender)
DomainKey-Signature: s=main; d=mail.utexas.edu; c=nofws; q=dns;
  h=X-IronPort-MID:Received:Received:Received:Subject:
   Mime-Version:Content-Type:From:In-Reply-To:Date:Cc:
   Content-Transfer-Encoding:Message-Id:References:To:
   X-Mailer;
  b=QxMwJBluMsO5yebwI3tnZjpRhlvKkFigAEiZF+9HqYMIsDC9DQvsjnm9
   Z16yiyFmLaWuzS5UHguGkJEjnYvmWhXiDzRcaTSJ3UMK2nSxtFLd68JI7
   yyEaf3wZZrAX8+fyJ4zmdWk4Vp+L1/ahi4ydgpimWgqROca1RLm0JH7wP
   0=;
Subject: Re: [PATCH] apr_hash_this_{key,klen,val}
Mime-Version: 1.0 (Apple Message framework v1077)
Content-Type: text/plain; charset=us-ascii
From: "Hyrum K. Wright" <hyrum_wright@mail.utexas.edu>
In-Reply-To: <4B96A8EF.8030401@rowe-clan.net>
Date: Tue, 9 Mar 2010 15:37:59 -0600
Cc: Jeff Trawick <trawick@gmail.com>,
 dev@apr.apache.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <C1D8D131-8FEC-4908-A285-496477E923B7@mail.utexas.edu>
References: <b51ffb6f1003090819g4d64f990w63e09e1c1a6bc1f@mail.gmail.com>
 <cc67648e1003090948i88cd76fl5b55a05f468fddaa@mail.gmail.com>
 <4B96A8EF.8030401@rowe-clan.net>
To: William A. Rowe Jr. <wrowe@rowe-clan.net>


On Mar 9, 2010, at 2:00 PM, William A. Rowe Jr. wrote:

> On 3/9/2010 11:48 AM, Jeff Trawick wrote:
>> On Tue, Mar 9, 2010 at 11:19 AM, Hyrum K. Wright
>> <hyrum_wright@mail.utexas.edu> wrote:
>>> In using the apr_hash datastructure in Subversion, we've found that =
we
>>> often only want the key or value from a hash.  Furthermore, casting
>>> the various return parameters has proven cumbersome.  To solve this
>>> problem, we've introduced three helper functions to return the key,
>>> key length, and value from a hash iterator.
>>>=20
>>> We've found these functions quite useful, so I'm including a patch =
to
>>> add them to APR proper.
>>=20
>> IMO these functions are a natural addition; any concerns from the =
crowd?
>>=20
>>> The patch is against trunk, but if possible,
>>> I'd like to see these APIs backported to 1.4.x and 1.5.x.
>>=20
>> too late for 1.4.x
>=20
> But not 1.5 - sounds like a great idea.  Only change I'd suggest is =
_key_len
> or even _keylen rather than _klen for an exported public function.

I'm fine with that.

I don't think I've got the appropriate karma to commit to APR, so =
whoever commits this patch can make that change (or would it be worse =
the hassle for me to create a new patch?).

I'm also planning a followup which const-ifies the apr_hash_index_t =
params to these functions, as well as apr_hash_this().  Thoughts?

-Hyrum=