Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: domain of gstein@gmail.com designates
 209.85.222.186 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=P+iXsv3Eu5uWItY4GnWLESaQtPxAtmW/8JzU5JCOMjjWuntMPyMX8E2y0XF6yr1EWC
         rgEAmEX66knsIu24OFQp5EfIVV3Nu9nVytqHSzBrbtYpM+Xf64PhXKZ/j7cdThQHj1OY
         euM19IN8j977ijJ8n/4pYVYaFh1TcQzK+1vrM=
MIME-Version: 1.0
In-Reply-To: <4B96C0C7.9000209@rowe-clan.net>
References: <b51ffb6f1003090819g4d64f990w63e09e1c1a6bc1f@mail.gmail.com>
	 <cc67648e1003090948i88cd76fl5b55a05f468fddaa@mail.gmail.com>
	 <4B96A8EF.8030401@rowe-clan.net>
	 <C1D8D131-8FEC-4908-A285-496477E923B7@mail.utexas.edu>
	 <4B96C0C7.9000209@rowe-clan.net>
Date: Fri, 12 Mar 2010 06:21:47 -0500
Message-ID: <6cca3db31003120321g524a5c4bo18aca952f6f0967b@mail.gmail.com>
Subject: Re: [PATCH] apr_hash_this_{key,klen,val}
From: Greg Stein <gstein@gmail.com>
To: "William A. Rowe Jr." <wrowe@rowe-clan.net>
Cc: dev@apr.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 9, 2010 at 16:42, William A. Rowe Jr. <wrowe@rowe-clan.net> wro=
te:
> On 3/9/2010 3:37 PM, Hyrum K. Wright wrote:
>>
>> I'm also planning a followup which const-ifies the apr_hash_index_t para=
ms to these functions, as well as apr_hash_this(). =A0Thoughts?
>
> Note const'ness will only be alterable with apr 2.0 forwards.

It is *totally* fine to add a 'const' to a parameter that was not
there before. That does not change the ABI whatsoever, and it will not
break the API for callers. It merely gives them more information at
compile time.

Cheers,
-g