Mailing-List: contact dev-help@apr.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of minfrin@sharp.fm designates
 72.32.122.20 as permitted sender)
Cc: dev@apr.apache.org
Message-Id: <2319527B-7107-42C4-A315-22D58D328D3F@sharp.fm>
From: Graham Leggett <minfrin@sharp.fm>
To: "William A. Rowe Jr." <wrowe@rowe-clan.net>
In-Reply-To: <4B9660E9.8060009@rowe-clan.net>
Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes
Content-Transfer-Encoding: 7bit
Mime-Version: 1.0 (Apple Message framework v936)
Subject: Re: svn commit: r920017 - in /apr/apr/branches/1.4.x: ./
  file_io/unix/open.c include/apr_file_io.h
Date: Tue, 9 Mar 2010 17:07:08 +0200
References: <20100307152436.70C7A23888DD@eris.apache.org>
 <cc67648e1003071454r4a9074beud1ccb490456d7c2f@mail.gmail.com>
 <63818FB9-89D1-44D9-883D-A0B6A6DE7AB2@sharp.fm>
 <cc67648e1003081253n4dd13ca5sa83222dfc6edaa2c@mail.gmail.com>
 <60FE5ECF-9E7B-4BF8-AF5B-9A76FBA31D35@sharp.fm>
 <cc67648e1003090346i4f970c54hdd931dbe4b45551d@mail.gmail.com>
 <7E6A163F-9782-4FF7-9F14-6C03E7CB7CE8@sharp.fm>
 <4B9660E9.8060009@rowe-clan.net>

On 09 Mar 2010, at 4:53 PM, William A. Rowe Jr. wrote:

>> In theory, when people try apr v1.5 for the first time, we're likely
>> to find out. I suspect it may be worth assuming support is present,
>> and then if it turns out that a platform that is still used doesn't
>> support it, we can then reintroduce the ifdef (and ENOTIMPL).
>
> -1 veto, please revert the backport.
>
> If you are experimenting on users, can we please keep that activity to
> trunk?  Some of us here are committed to offering developers a stable
> library of features they can count on.  Thanks in advance.

You're vetoing a patch that I haven't even written yet??? Based on us  
"experimenting" on a branch that hasn't been released yet???

What I was suggesting was to remove the #ifdef and make the assumption  
that O_NONBLOCK is supported on all unix platforms on apr v1.5, and  
fixing this assertion if it turns out to not be true *before*  
releasing v1.5.0. If you believe this is too onerous on users that's  
entirely fine, but then say so. There is no need to wave around a -1  
in the air, I am perfectly happy to accept your objection without  
being bashed over the head with a veto.

Regards,
Graham
--