Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 37582 invoked from network); 12 Mar 2010 10:49:19 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 12 Mar 2010 10:49:19 -0000 Received: (qmail 58622 invoked by uid 500); 12 Mar 2010 10:48:42 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 58281 invoked by uid 500); 12 Mar 2010 10:48:42 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 58269 invoked by uid 99); 12 Mar 2010 10:48:41 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Mar 2010 10:48:41 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [209.85.219.228] (HELO mail-ew0-f228.google.com) (209.85.219.228) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 12 Mar 2010 10:48:32 +0000 Received: by ewy28 with SMTP id 28so61155ewy.33 for ; Fri, 12 Mar 2010 02:48:12 -0800 (PST) Received: by 10.213.96.210 with SMTP id i18mr2834818ebn.29.1268390891206; Fri, 12 Mar 2010 02:48:11 -0800 (PST) Received: from tcgws000 (183-019-045-062.static.caiway.nl [62.45.19.183]) by mx.google.com with ESMTPS id 16sm814927ewy.7.2010.03.12.02.48.10 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 12 Mar 2010 02:48:10 -0800 (PST) From: "Bert Huijben" To: References: <20100310111828.EDDEF2388900@eris.apache.org> In-Reply-To: <20100310111828.EDDEF2388900@eris.apache.org> Subject: RE: svn commit: r921306 - /apr/apr/branches/1.5.x/file_io/win32/open.c Date: Fri, 12 Mar 2010 11:48:09 +0100 Message-ID: <00c601cac1d1$81f408e0$85dc1aa0$@qqmail.nl> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQGmf569mPT8ZC6hYXfXvfBx4bUiOgGVs0md Content-Language: nl X-Virus-Checked: Checked by ClamAV on apache.org > -----Original Message----- > From: jfclere@apache.org [mailto:jfclere@apache.org] > Sent: woensdag 10 maart 2010 12:18 > To: commits@apr.apache.org > Subject: svn commit: r921306 - > /apr/apr/branches/1.5.x/file_io/win32/open.c >=20 > Author: jfclere > Date: Wed Mar 10 11:18:28 2010 > New Revision: 921306 >=20 > URL: http://svn.apache.org/viewvc?rev=3D921306&view=3Drev > Log: > typos? Otherwise it won't compile. >=20 > Modified: > apr/apr/branches/1.5.x/file_io/win32/open.c >=20 > Modified: apr/apr/branches/1.5.x/file_io/win32/open.c > URL: > = http://svn.apache.org/viewvc/apr/apr/branches/1.5.x/file_io/win32/open.c > ?rev=3D921306&r1=3D921305&r2=3D921306&view=3Ddiff > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- apr/apr/branches/1.5.x/file_io/win32/open.c (original) > +++ apr/apr/branches/1.5.x/file_io/win32/open.c Wed Mar 10 11:18:28 = 2010 > @@ -605,8 +605,8 @@ APR_DECLARE(apr_status_t) apr_file_link( > #endif > #if APR_HAS_ANSI_FS > ELSE_WIN_OS_IS_ANSI { > - if (!CreateHardLinkA(wto_path, wfrom_path)) > - return apr_get_os_error() > + if (!CreateHardLinkA(to_path, from_path)) > + return apr_get_os_error(); > } > #endif > return rv; >=20 Why do we even have this block? CreateHardLinkA is only implemented in Windows 2000 and later, which = implies unicode support.=20 (Why support an ansi version of an API that is only implemented on = unicode capable systems?) Bert