apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <...@cs.berkeley.edu>
Subject Re: struct apr_pollfd_t pool member?
Date Tue, 30 Mar 2010 17:02:19 GMT
Field seems unused to me -- +1 for removing it. Attached is a patch
against trunk that does this.

Since this struct is exposed to client code, removing the field is
presumably only an option for APR2.

Neil

On Mon, Mar 29, 2010 at 9:54 AM, Stefan Ruppert <ml@ruppert-it.de> wrote:
> Hi all,
>
> today I noticed that the pool member in the apr_pollfd_t structure isn't
> used at all within APR! Why should there an associated memory pool? What is
> the purpose of this field then?
>
> From include/apr_poll.h:
>
> /** Poll descriptor set. */
> struct apr_pollfd_t {
>    apr_pool_t *p;              /**< associated pool */
>    apr_datatype_e desc_type;   /**< descriptor type */
>    apr_int16_t reqevents;      /**< requested events */
>    apr_int16_t rtnevents;      /**< returned events */
>    apr_descriptor desc;        /**< @see apr_descriptor */
>    void *client_data;          /**< allows app to associate context */
> };
>
>
> Regards,
> Stefan
>

Mime
View raw message