apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe Jr." <wr...@rowe-clan.net>
Subject Re: [PATCH] apr_hash_this_{key,klen,val}
Date Fri, 12 Mar 2010 22:14:04 GMT
[obviously, had not had enough coffee]

On 3/12/2010 1:39 PM, Greg Stein wrote:
> 
> We're talking about a function prototype that current says:
> 
> APR_DECLARE(void) apr_hash_this(apr_hash_index_t *hi, const void **key,
>                                 apr_ssize_t *klen, void **val);

> and add a const to a parameter, thusly:
> 
> APR_DECLARE(void) apr_hash_this(const apr_hash_index_t *hi, const void **key,
>                                 apr_ssize_t *klen, void **val);
> 
> 
> THAT is a compatible change.

aren't key and ssize wrong?

const void * const * key

const apr_ssize_t *klen

Is val volatile?

Mime
View raw message