apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bert Huijben" <b...@qqmail.nl>
Subject RE: svn commit: r921306 - /apr/apr/branches/1.5.x/file_io/win32/open.c
Date Fri, 12 Mar 2010 10:48:09 GMT


> -----Original Message-----
> From: jfclere@apache.org [mailto:jfclere@apache.org]
> Sent: woensdag 10 maart 2010 12:18
> To: commits@apr.apache.org
> Subject: svn commit: r921306 -
> /apr/apr/branches/1.5.x/file_io/win32/open.c
> 
> Author: jfclere
> Date: Wed Mar 10 11:18:28 2010
> New Revision: 921306
> 
> URL: http://svn.apache.org/viewvc?rev=921306&view=rev
> Log:
> typos? Otherwise it won't compile.
> 
> Modified:
>     apr/apr/branches/1.5.x/file_io/win32/open.c
> 
> Modified: apr/apr/branches/1.5.x/file_io/win32/open.c
> URL:
> http://svn.apache.org/viewvc/apr/apr/branches/1.5.x/file_io/win32/open.c
> ?rev=921306&r1=921305&r2=921306&view=diff
> ==========================================================
> ====================
> --- apr/apr/branches/1.5.x/file_io/win32/open.c (original)
> +++ apr/apr/branches/1.5.x/file_io/win32/open.c Wed Mar 10 11:18:28 2010
> @@ -605,8 +605,8 @@ APR_DECLARE(apr_status_t) apr_file_link(
>  #endif
>  #if APR_HAS_ANSI_FS
>      ELSE_WIN_OS_IS_ANSI {
> -        if (!CreateHardLinkA(wto_path, wfrom_path))
> -                return apr_get_os_error()
> +        if (!CreateHardLinkA(to_path, from_path))
> +                return apr_get_os_error();
>      }
>  #endif
>      return rv;
> 

Why do we even have this block?

CreateHardLinkA is only implemented in Windows 2000 and later, which implies unicode support.

(Why support an ansi version of an API that is only implemented on unicode capable systems?)

	Bert



Mime
View raw message