From dev-return-22945-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Wed Feb 17 12:17:49 2010 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 50474 invoked from network); 17 Feb 2010 12:17:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 17 Feb 2010 12:17:48 -0000 Received: (qmail 65718 invoked by uid 500); 17 Feb 2010 12:17:48 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 65633 invoked by uid 500); 17 Feb 2010 12:17:47 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 65625 invoked by uid 99); 17 Feb 2010 12:17:47 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Feb 2010 12:17:47 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of trawick@gmail.com designates 209.85.210.204 as permitted sender) Received: from [209.85.210.204] (HELO mail-yx0-f204.google.com) (209.85.210.204) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Feb 2010 12:17:39 +0000 Received: by yxe42 with SMTP id 42so5463032yxe.22 for ; Wed, 17 Feb 2010 04:17:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=CHwzPISVAYrajYliJnOcTOwz5HJwQlM9kjv030ff4qA=; b=b2XoqZU5DqXO8xPL4KNTJ8DxOkgPNMfzfHBJO3zPY1hLz0mwx6iOseVqPm6oZCYDvs 01x+hBpeNbdv0P/8+ZXRbezCcr5wz6/e5ihRK1v06jNlLadf0CgPVOhj1wxDKtx3UDOU 55+kOfa2GEOn4vKUBu3NW/q+yCE8/iJAHcvxs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=qaoCGXT2hQzhty4EsLPNM9EzbcCNH4uCSdOLOnHvBbhMrJnDCnecaSogoX1BnsvmIV +NwNk+NvYLIDnCpVqQzjQRiNJh0/8n+s4PX3bKh37zLZa3aZTRAfscKC+va/M/sIv0YC XXZ9toLNVk8d1lUu6ddBBBx/x3KWSh/iMYGR8= MIME-Version: 1.0 Received: by 10.100.56.22 with SMTP id e22mr6388337ana.228.1266409039045; Wed, 17 Feb 2010 04:17:19 -0800 (PST) In-Reply-To: <20100217094838.GA4173@redhat.com> References: <20100203101811.9ABA623888BD@eris.apache.org> <20100217094838.GA4173@redhat.com> Date: Wed, 17 Feb 2010 07:17:19 -0500 Message-ID: Subject: Re: svn commit: r905970 - in /apr/apr/trunk: file_io/unix/filedup.c file_io/unix/open.c file_io/unix/readwrite.c include/apr_file_io.h include/arch/unix/apr_arch_file_io.h From: Jeff Trawick To: dev@apr.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Wed, Feb 17, 2010 at 4:48 AM, Joe Orton wrote: > On Wed, Feb 03, 2010 at 10:18:04AM -0000, Paul Querna wrote: >> Author: pquerna >> Date: Wed Feb =A03 10:17:57 2010 >> New Revision: 905970 >> >> URL: http://svn.apache.org/viewvc?rev=3D905970&view=3Drev >> Log: >> Add two new features to APR Files: >> =A0- When opened with normal rotating flag, every 60 seconds the file wi= ll check >> =A0 =A0if the file it is writing to has changed inode (ie, been replaced= /moved). >> =A0- When opened with the manual rotating flag, the consumer must call t= he check, >> =A0 =A0but can provider the current timestamp, to avoid a apr_time call. >> >> This is based off of the patch from Brian, but I've modified it for styl= e, and >> adding the manual rotation flag after discussion with brian at the httpd >> hackathon. > > Why do this in APR? =A0This seems like a fairly obscure feature to try to > shoehorn into apr_file_*. FWIW, that was my reaction to seeing this committed. It feels fragile for the long haul, but interest in the community would certainly mitigate that. Perhaps this was first discussed with other APR colleagues at the recent httpd hackathon; otherwise, the neighborly thing to do would be to discuss this on the list first and get some buy-in (intentionally side-stepping the "it didn't happen if it didn't happen on the list" meme :) ) Who wants it to keep working bad enough to write testcases for it or get it working on Windows?