From dev-return-22867-apmail-apr-dev-archive=apr.apache.org@apr.apache.org Wed Feb 03 19:45:48 2010 Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 93714 invoked from network); 3 Feb 2010 19:45:48 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 3 Feb 2010 19:45:48 -0000 Received: (qmail 95347 invoked by uid 500); 3 Feb 2010 19:45:47 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 95239 invoked by uid 500); 3 Feb 2010 19:45:46 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 95230 invoked by uid 99); 3 Feb 2010 19:45:46 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Feb 2010 19:45:46 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Wed, 03 Feb 2010 19:45:37 +0000 Received: (qmail 93416 invoked by uid 2161); 3 Feb 2010 19:45:15 -0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) by hilbert.heimnetz.de (Postfix) with ESMTP id 37E106045 for ; Wed, 3 Feb 2010 20:45:17 +0100 (CET) Message-ID: <4B69D24D.1050101@gmx.de> Date: Wed, 03 Feb 2010 20:45:17 +0100 From: =?UTF-8?B?UsO8ZGlnZXIgUGzDvG0=?= User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.8.1.23) Gecko/20090823 SeaMonkey/1.1.18 MIME-Version: 1.0 To: dev@apr.apache.org Subject: Re: svn commit: r905970 - in /apr/apr/trunk: file_io/unix/filedup.c file_io/unix/open.c file_io/unix/readwrite.c include/apr_file_io.h include/arch/unix/apr_arch_file_io.h References: <20100203101811.9ABA623888BD@eris.apache.org> In-Reply-To: <20100203101811.9ABA623888BD@eris.apache.org> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org On 03.02.2010 11:18, pquerna@apache.org wrote: > Author: pquerna > Date: Wed Feb 3 10:17:57 2010 > New Revision: 905970 > > URL: http://svn.apache.org/viewvc?rev=905970&view=rev > Log: > Add two new features to APR Files: > - When opened with normal rotating flag, every 60 seconds the file will check > if the file it is writing to has changed inode (ie, been replaced/moved). > - When opened with the manual rotating flag, the consumer must call the check, > but can provider the current timestamp, to avoid a apr_time call. > > This is based off of the patch from Brian, but I've modified it for style, and > adding the manual rotation flag after discussion with brian at the httpd > hackathon. > > Submitted by: Brian J. France > > Modified: > apr/apr/trunk/file_io/unix/filedup.c > apr/apr/trunk/file_io/unix/open.c > apr/apr/trunk/file_io/unix/readwrite.c > apr/apr/trunk/include/apr_file_io.h > apr/apr/trunk/include/arch/unix/apr_arch_file_io.h This breaks compilation of httpd trunk: server/.libs/libmain.a(exports.o):(.data+0x1540): undefined reference to `apr_file_rotating_manual_check' collect2: ld returned 1 exit status make[1]: *** [httpd] Fehler 1 make: *** [all-recursive] Fehler 1 Regards Rüdiger