Return-Path: Delivered-To: apmail-apr-dev-archive@www.apache.org Received: (qmail 8499 invoked from network); 21 Jan 2010 10:48:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 21 Jan 2010 10:48:28 -0000 Received: (qmail 39459 invoked by uid 500); 21 Jan 2010 10:48:27 -0000 Delivered-To: apmail-apr-dev-archive@apr.apache.org Received: (qmail 39363 invoked by uid 500); 21 Jan 2010 10:48:27 -0000 Mailing-List: contact dev-help@apr.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: List-Id: Delivered-To: mailing list dev@apr.apache.org Received: (qmail 39355 invoked by uid 99); 21 Jan 2010 10:48:27 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jan 2010 10:48:27 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of minfrin@sharp.fm designates 72.32.122.20 as permitted sender) Received: from [72.32.122.20] (HELO chandler.sharp.fm) (72.32.122.20) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jan 2010 10:48:18 +0000 Received: from chandler.sharp.fm (localhost [127.0.0.1]) by chandler.sharp.fm (Postfix) with ESMTP id 0E52178109; Thu, 21 Jan 2010 04:47:57 -0600 (CST) Received: from 87-194-125-14.bethere.co.uk (87-194-125-14.bethere.co.uk [87.194.125.14]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (Client did not present a certificate) (Authenticated sender: minfrin@sharp.fm) by chandler.sharp.fm (Postfix) with ESMTP id 62E5D78093; Thu, 21 Jan 2010 04:47:56 -0600 (CST) Cc: dev@apr.apache.org, minfrin@apache.org Message-Id: <7025984C-C9BA-4ACB-85E0-AF6A9B08C083@sharp.fm> From: Graham Leggett To: William A. Rowe Jr. In-Reply-To: <4B56A396.1090206@rowe-clan.net> Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v936) Subject: Re: svn commit: r899905 - in /apr/apr/trunk: include/ include/arch/unix/ poll/unix/ test/ Date: Thu, 21 Jan 2010 12:47:55 +0200 References: <20100116085347.3E6272388993@eris.apache.org> <4B56A396.1090206@rowe-clan.net> X-Mailer: Apple Mail (2.936) X-Virus-Scanned: ClamAV using ClamSMTP X-Virus-Checked: Checked by ClamAV on apache.org On 20 Jan 2010, at 8:32 AM, William A. Rowe Jr. wrote: >> /* Private functions */ >> -void apr_pollset_drain_wakeup_pipe(apr_pollset_t *pollset); >> +apr_status_t create_wakeup_pipe(apr_pool_t *pool, apr_pollfd_t >> *pfd, apr_file_t **wakeup_pipe); >> +apr_status_t close_wakeup_pipe(apr_file_t **wakeup_pipe); > > Although these are not exported for dynamic builds, aren't we > violating > the principal of least surprise with respect to binding to a static > libapr.a archive? (Was waiting for Neil to respond). Is it enough to declare these as static? I would imagine this was an oversight. Regards, Graham --