apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <...@cs.berkeley.edu>
Subject Re: svn commit: r899905 - in /apr/apr/trunk: include/ include/arch/unix/ poll/unix/ test/
Date Thu, 21 Jan 2010 19:01:35 GMT
The functions can't be static, because they are referenced from > 1 source file.

Attached is a patch that adds apr_pollset prefixes for the private functions.

Neil

On Thu, Jan 21, 2010 at 2:47 AM, Graham Leggett <minfrin@sharp.fm> wrote:
> On 20 Jan 2010, at 8:32 AM, William A. Rowe Jr. wrote:
>
>>> /* Private functions */
>>> -void apr_pollset_drain_wakeup_pipe(apr_pollset_t *pollset);
>>> +apr_status_t create_wakeup_pipe(apr_pool_t *pool, apr_pollfd_t *pfd,
>>> apr_file_t **wakeup_pipe);
>>> +apr_status_t close_wakeup_pipe(apr_file_t **wakeup_pipe);
>>
>> Although these are not exported for dynamic builds, aren't we violating
>> the principal of least surprise with respect to binding to a static
>> libapr.a archive?
>
> (Was waiting for Neil to respond). Is it enough to declare these as static?
> I would imagine this was an oversight.
>
> Regards,
> Graham
> --
>
>

Mime
View raw message