apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <...@cs.berkeley.edu>
Subject [PATCH] bug in pollset_wakeup() + nocopy
Date Thu, 07 Jan 2010 01:47:42 GMT
apr_pollset_wakeup() is buggy when used with APR_POLLSET_NOCOPY,
because create_wakeup_pipe() passes a stack-allocated apr_pollfd_t to
apr_pollset_add(). This is unsafe if the user specified
APR_POLLSET_NOCOPY when creating the pollset.

The attached patch fixes this by adding an apr_pollfd_t for the wakeup
pipe to apr_pollset_t, so that it has a sufficiently-long-lived
lifetime.

Neil

Mime
View raw message