apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Graham Leggett <minf...@sharp.fm>
Subject Re: svn commit: r890580 - in /apr/apr-util/branches/1.4.x: crypto/apr_crypto.c crypto/apr_crypto_nss.c crypto/apr_crypto_openssl.c include/apr_crypto.h include/private/apr_crypto_internal.h test/testcrypto.c
Date Sat, 16 Jan 2010 09:11:20 GMT
On 15 Dec 2009, at 8:52 PM, William A. Rowe Jr. wrote:

> Hold off... it is not incompatible (well, you can slide *errfn to the
> last element of the structure, but otherwise)...
>
> What we need is a way to document *and validate* incomplete C types
> into complete C types with structures.  The approach in apr_general.h
> or somewhere similar would be;
>
> #if APR_HAVE_VOID_INCOMPLETE_TYPES
> #define APR_TYPEDEF_STRUCT(type, incompletion) \
> typedef struct type {
>    incompletion
>    void unk[];
> } type;
> #else
> typedef struct type type;
> #endif
>
> and then within apr_foo.h, an particular example;
>
> APR_TYPEDEF_STRUCT(apr_foo_t, \
>    apr_pool_t    *pool;      \
>    apr_foo_ctx_t *ctx;       \
> )
>
> or something very closely resembling this.  Need to work out the exact
> mechanics that aren't subject to macro problems, and the autoconf  
> magic
> to detect the availability.
>
> My gut says hold off releasing apr-1.4.1 for just a bit to see if this
> feature would be the solution.

I've come up with r899910, and it seems to work. Can you give it the  
once over for me if possible?

Regards,
Graham
--


Mime
View raw message