apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guenter Knauf <fua...@apache.org>
Subject Re: [VOTE] release apr-1.4.2?
Date Mon, 25 Jan 2010 00:05:38 GMT
Guenter Knauf schrieb:
> BTW. while I was on that found that in httpd's roll.sh the gpg signing
> part looks wrong to me - therefore I kept the way how the signing user
> is handled same as was before in apr's release.h; but I believe it
> should be fixed for httpd's roll.sh:
> 
> --- roll.sh.orig        2010-01-25 00:41:13.000000000 +0100
> +++ roll.sh     2010-01-25 00:41:13.000000000 +0100
> @@ -179,10 +179,8 @@
>    done
>  # no pgp found - check for gpg
>  elif test -x "${gpg}"; then
> -  if test -z "${user}"; then
> -    args="--default-key ${args}"
> -  else
> -    args="-u ${user} ${args}"
> +  if test -n "${user}"; then
> +    args="--default-key ${user}"
>    fi
>    for file; do
>      if test -f "${file}"; then
> 
> comments?
hmmm, just looked at man page from gpg 2.0.9, and from that it looks as
if httpd's roll.sh is right, and apr's release.sh was/is therefore wrong:
--default-key name
       Use name as the default key to sign with. If this option is not
used, the default key  is  the  first
       key found in the secret keyring.  Note that -u or --local-user
overrides this option.

Gün.



Mime
View raw message