apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guenter Knauf <fua...@apache.org>
Subject Re: [VOTE] release apr-1.4.2?
Date Sun, 24 Jan 2010 23:45:14 GMT
Hi Jeff.
Jeff Trawick schrieb:
> (I hope this doesn't start another long hash format thread) perhaps
> Guenter would want to update the apr roll script (if there is one) to
> massage the md5 sums as appropriate for future releases :)
> 
> apr-1.4.2.tar.bz2: 4B 00 E8 F7 0C 06 78 93  D0 75 57 79 62 65 6B 35
hehe, thanks for the hint! Just copied the relevant part from httpd's
roll.sh over to apr's release.h - hopefully without introducing errors
:) This also now adds sha1 sums to apr releases.

BTW. while I was on that found that in httpd's roll.sh the gpg signing
part looks wrong to me - therefore I kept the way how the signing user
is handled same as was before in apr's release.h; but I believe it
should be fixed for httpd's roll.sh:

--- roll.sh.orig        2010-01-25 00:41:13.000000000 +0100
+++ roll.sh     2010-01-25 00:41:13.000000000 +0100
@@ -179,10 +179,8 @@
   done
 # no pgp found - check for gpg
 elif test -x "${gpg}"; then
-  if test -z "${user}"; then
-    args="--default-key ${args}"
-  else
-    args="-u ${user} ${args}"
+  if test -n "${user}"; then
+    args="--default-key ${user}"
   fi
   for file; do
     if test -f "${file}"; then

comments?

Gün.



Mime
View raw message