apr-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe Jr." <wr...@rowe-clan.net>
Subject Re: svn commit: r899905 - in /apr/apr/trunk: include/ include/arch/unix/ poll/unix/ test/
Date Thu, 21 Jan 2010 17:58:37 GMT
On 1/21/2010 4:47 AM, Graham Leggett wrote:
> On 20 Jan 2010, at 8:32 AM, William A. Rowe Jr. wrote:
> 
>>> /* Private functions */
>>> -void apr_pollset_drain_wakeup_pipe(apr_pollset_t *pollset);
>>> +apr_status_t create_wakeup_pipe(apr_pool_t *pool, apr_pollfd_t *pfd,
>>> apr_file_t **wakeup_pipe);
>>> +apr_status_t close_wakeup_pipe(apr_file_t **wakeup_pipe);
>>
>> Although these are not exported for dynamic builds, aren't we violating
>> the principal of least surprise with respect to binding to a static
>> libapr.a archive?
> 
> (Was waiting for Neil to respond). Is it enough to declare these as
> static? I would imagine this was an oversight.

How do you declare them static when living in another source module?

Mime
View raw message